Changeset 4846

Timestamp:

01/31/2017 11:54:44 PM (8 years ago)

Author:

coffee2code

Message:

Support Theme: Link "Forums" in menu to "/#bbpress-forums".

It now more aptly leads to actual forums listing and no longer duplicates the link target of the preceding "Support" link.

Fixes #2455.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/header.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/header.php

@@ -14 +14 @@
 $menu_items = array(
     /* translators: relative link to the forums home page */
-    _x( '/', 'header menu', 'wporg-forums' )                                            => _x( 'Forums', 'header menu', 'wporg-forums' ),
+    _x( '/#bbpress-forums', 'header menu', 'wporg-forums' )                             => _x( 'Forums', 'header menu', 'wporg-forums' ),
     _x( 'https://codex.wordpress.org/Main_Page', 'header menu', 'wporg-forums' )        => _x( 'Documentation', 'header menu', 'wporg-forums' ),
     _x( 'https://make.wordpress.org/support/handbook/', 'header menu', 'wporg-forums' ) => _x( 'Get Involved', 'header menu', 'wporg-forums' ),
@@ -47 +47 @@
                                 <?php
                                 foreach ( $menu_items as $path => $text ) :
-                                    $class = false !== strpos( $_SERVER['REQUEST_URI'], $path ) ? 'class="active" ' : '';
+                                    $class = '';
                                     $url = parse_url( $path );
                                     if ( ! empty( $url['host' ] ) ) {
                                         $url = esc_url( $path );
                                     } else {
+                                        $class = false !== strpos( $_SERVER['REQUEST_URI'], $url['path'] ) ? 'class="active" ' : '';
                                         $url = esc_url( home_url( $path ) );
                                     }