Changeset 4894

Timestamp:

02/08/2017 08:21:45 PM (8 years ago)

Author:

coffee2code

Message:

Support Forums: Omit forum link from breadcrumbs for plugin/theme support forums and reviews

Their general forums are hidden from listings and no longer meant to be directly linked.

Fixes #2486.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc

Files:

• class-directory-compat.php (modified) (1 diff)
• class-support-compat.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -447 +447 @@
         }
 
-        $r[1] = '<a href="' . esc_url( bbp_get_forum_permalink( $this->forum_id() ) ) . '" class="bbp-breadcrumb-forum">' . esc_html( bbp_get_forum_title( $this->forum_id() ) ) . '</a>';
-        $r[2] = esc_html( $this->title() );
+        $r[1] = esc_html( $this->title() );
         if ( in_array( $view, array( 'reviews', 'active' ) ) ) {
-            $r[2] = '<a href="' . esc_url( bbp_get_view_url( $this->compat() ) ) . '" class="bbp-breadcrumb-forum">' . esc_html( $this->title() ) . '</a>';
+            // Prefix link to plugin/theme support or review forum with context.
+            if ( 'plugin' === $this->compat() ) {
+                /* translators: %s: link to plugin support or review forum */
+                $parent_breadcrumb = __( 'Plugin: %s', 'wporg-forums' );
+            } else {
+                /* translators: %s: link to theme support or review forum */
+                $parent_breadcrumb = __( 'Theme: %s', 'wporg-forums' );
+            }
+            $r[1] = sprintf( $parent_breadcrumb, sprintf(
+                '<a href="%s" class="bbp-breadcrumb-forum">%s</a>',
+                esc_url( bbp_get_view_url( $this->compat() ) ),
+                esc_html( $this->title() )
+            ) );
             if ( 'reviews' == $view ) {
-                $r[3] = __( 'Reviews', 'wporg-forums' );
+                $r[2] = __( 'Reviews', 'wporg-forums' );
             } else {
-                $r[3] = __( 'Active Topics', 'wporg-forums' );
+                $r[2] = __( 'Active Topics', 'wporg-forums' );
             }
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-support-compat.php

@@ -463 +463 @@
         }
 
-        $link = sprintf(
+        // Prefix link to plugin/theme support or review forum with context.
+        if ( 'plugin' === $type ) {
+            /* translators: %s: link to plugin support or review forum */
+            $parent_breadcrumb = __( 'Plugin: %s', 'wporg-forums' );
+        } else {
+            /* translators: %s: link to theme support or review forum */
+            $parent_breadcrumb = __( 'Theme: %s', 'wporg-forums' );
+        }
+        $link = sprintf( $parent_breadcrumb, sprintf(
             '<a href="%s" class="bbp-breadcrumb-forum">%s</a>',
             esc_url( $url ),
             esc_html( $obj->post_title )
-        );
+        ) );
 
         // Insert link before topic title.
-        array_splice( $r, 2, 0, $link );
+        array_splice( $r, 1, 1, $link );
 
         return $r;