Changeset 4900

Timestamp:

02/14/2017 03:54:43 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: API: Sort the ratings API response from 5..1 for compatibility with WordPress.

Props SergeyBiryukov.
Fixes #2468.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• api/routes/class-plugin.php (modified) (1 diff)
• tests/phpunit/tests/wporg-plugin-api.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin.php

@@ -103 +103 @@
         $result['rating'] = ( get_post_meta( $post_id, 'rating', true ) ?: 0 ) * 20; // Stored as 0.0 ~ 5.0, API outputs as 0..100
         $result['ratings'] = array_map( 'intval', (array) get_post_meta( $post_id, 'ratings', true ) );
+        krsort( $result['ratings'] );
+
         $result['num_ratings'] = array_sum( $result['ratings'] );
         $result['support_threads'] = intval( get_post_meta( $post_id, 'support_threads', true ) );

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tests/phpunit/tests/wporg-plugin-api.php

@@ -249 +249 @@
         $this->assertObjectHasAttribute( 'ratings', $plugin_info, 'Ratings exists' );
         $this->assertAttributeInternalType( 'array', 'ratings', $plugin_info, 'Ratings should be an array' );
+        $this->assertEquals( array( 5, 4, 3, 2, 1 ), array_keys( $plugin_info->ratings ), 'Ratings should be ordered from 5 to 1' );
         $this->assertArrayHasKey( '1', $plugin_info->ratings, 'Rating should have an attribute of 1' );
         $this->assertArrayHasKey( '2', $plugin_info->ratings, 'Rating should have an attribute of 2' );