Changeset 5016

Timestamp:

02/28/2017 05:44:24 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Add some sane pagination defaults for plugin queries. Asking for more than 250 items, or for page 1,000 easily bumps up against limits.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-query-plugins.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-query-plugins.php

@@ -50 +50 @@
         $query = array_intersect_key( $request->get_params(), array_flip( $this->valid_query_fields ) );
 
+        // Add some sane pagination limits to prevent insane queries.
+        if ( isset( $query['paged'] ) ) {
+            $query['paged'] = min( $query['paged'], 999 );
+        }
+        if ( isset( $query['posts_per_page'] ) ) {
+            $query['posts_per_page'] = min( $query['posts_per_page'], 250 );
+        }
+
         if ( ! $query ) {
             return $response;