Changeset 5044 for sites/trunk/buddypress.org/public_html/wp-content/themes/bb-base/bbpress/form-topic.php

Timestamp:

03/02/2017 04:31:33 AM (8 years ago)

Author:

netweb

Message:

BuddyPress.org/bbPress.org: Remove tabindex attributes from bbPress topic forms to restore normal focus order.

Hat tip SergeyBiryukov, anevins.
Fixes #2553. See ​#bb2714.

File:

• sites/trunk/buddypress.org/public_html/wp-content/themes/bb-base/bbpress/form-topic.php (modified) (7 diffs)

sites/trunk/buddypress.org/public_html/wp-content/themes/bb-base/bbpress/form-topic.php

@@ -63 +63 @@
                     <p>
                         <label for="bbp_topic_title"><?php printf( __( 'Topic Title (Maximum Length: %d):', 'bbpress' ), bbp_get_title_max_length() ); ?></label><br />
-                        <input type="text" id="bbp_topic_title" value="<?php bbp_form_topic_title(); ?>" tabindex="<?php bbp_tab_index(); ?>" size="40" name="bbp_topic_title" maxlength="<?php bbp_title_max_length(); ?>" />
+                        <input type="text" id="bbp_topic_title" value="<?php bbp_form_topic_title(); ?>" size="40" name="bbp_topic_title" maxlength="<?php bbp_title_max_length(); ?>" />
                     </p>
 
@@ -74 +74 @@
                         <p>
                             <label for="bbp_reply_content"><?php _e( 'Reply:', 'bbpress' ); ?></label><br />
-                            <textarea id="bbp_topic_content" tabindex="<?php bbp_tab_index(); ?>" name="bbp_topic_content" cols="60" rows="6"><?php bbp_form_topic_content(); ?></textarea>
+                            <textarea id="bbp_topic_content" name="bbp_topic_content" cols="60" rows="6"><?php bbp_form_topic_content(); ?></textarea>
                         </p>
 
@@ -98 +98 @@
                     <p>
                         <label for="bbp_topic_tags"><?php _e( 'Topic Tags:', 'bbpress' ); ?></label><br />
-                        <input type="text" value="<?php bbp_form_topic_tags(); ?>" tabindex="<?php bbp_tab_index(); ?>" size="40" name="bbp_topic_tags" id="bbp_topic_tags" <?php disabled( bbp_is_topic_spam() ); ?> />
+                        <input type="text" value="<?php bbp_form_topic_tags(); ?>" size="40" name="bbp_topic_tags" id="bbp_topic_tags" <?php disabled( bbp_is_topic_spam() ); ?> />
                     </p>
 
@@ -137 +137 @@
 
                         <p>
-                            <input name="bbp_topic_subscription" id="bbp_topic_subscription" type="checkbox" value="bbp_subscribe" <?php bbp_form_topic_subscribed(); ?> tabindex="<?php bbp_tab_index(); ?>" />
+                            <input name="bbp_topic_subscription" id="bbp_topic_subscription" type="checkbox" value="bbp_subscribe" <?php bbp_form_topic_subscribed(); ?> />
 
                             <?php if ( bbp_is_topic_edit() && ( get_the_author_meta( 'ID' ) != bbp_get_current_user_id() ) ) : ?>
@@ -161 +161 @@
                             <legend><?php _e( 'Revision', 'bbpress' ); ?></legend>
                             <div>
-                                <input name="bbp_log_topic_edit" id="bbp_log_topic_edit" type="checkbox" value="1" <?php bbp_form_topic_log_edit(); ?> tabindex="<?php bbp_tab_index(); ?>" />
+                                <input name="bbp_log_topic_edit" id="bbp_log_topic_edit" type="checkbox" value="1" <?php bbp_form_topic_log_edit(); ?> />
                                 <label for="bbp_log_topic_edit"><?php _e( 'Keep a log of this edit:', 'bbpress' ); ?></label><br />
                             </div>
@@ -167 +167 @@
                             <div>
                                 <label for="bbp_topic_edit_reason"><?php printf( __( 'Optional reason for editing:', 'bbpress' ), bbp_get_current_user_name() ); ?></label><br />
-                                <input type="text" value="<?php bbp_form_topic_edit_reason(); ?>" tabindex="<?php bbp_tab_index(); ?>" size="40" name="bbp_topic_edit_reason" id="bbp_topic_edit_reason" />
+                                <input type="text" value="<?php bbp_form_topic_edit_reason(); ?>" size="40" name="bbp_topic_edit_reason" id="bbp_topic_edit_reason" />
                             </div>
                         </fieldset>
@@ -181 +181 @@
                         <?php do_action( 'bbp_theme_before_topic_form_submit_button' ); ?>
 
-                        <button type="submit" tabindex="<?php bbp_tab_index(); ?>" id="bbp_topic_submit" name="bbp_topic_submit" class="button submit"><?php _e( 'Submit', 'bbpress' ); ?></button>
+                        <button type="submit" id="bbp_topic_submit" name="bbp_topic_submit" class="button submit"><?php _e( 'Submit', 'bbpress' ); ?></button>
 
                         <?php do_action( 'bbp_theme_after_topic_form_submit_button' ); ?>