Changeset 5118

Timestamp:

03/07/2017 10:17:39 PM (10 years ago)

Author:

coreymckrill

Message:

WC Remote CSS: Don't use a translated string as an ID

In #4966, making the tab labels translatable introduced the possibility
of a fatal error, because the label became part of the required filename.
This removes the possibility by using a separate ID string for the filename.

See #2377

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-remote-css/app/user-interface.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-remote-css/app/user-interface.php

@@ -193 +193 @@
         $screen = get_current_screen();
         $tabs   = array(
-                __( 'Overview',                  'wordcamporg' ),
-                __( 'Basic Setup',               'wordcamporg' ),
-                __( 'Automated Synchronization', 'wordcamporg' ),
-                __( 'Tips',                      'wordcamporg' )
+                'overview'                  => __( 'Overview',                  'wordcamporg' ),
+                'basic-setup'               => __( 'Basic Setup',               'wordcamporg' ),
+                'automated-synchronization' => __( 'Automated Synchronization', 'wordcamporg' ),
+                'tips'                      => __( 'Tips',                      'wordcamporg' )
         );
 
-        foreach ( $tabs as $tab ) {
+        foreach ( $tabs as $id => $label ) {
                 $screen->add_help_tab( array(
-                        'id'       => 'wcrcss-' . sanitize_title( $tab ),
-                        'title'    => $tab,
+                        'id'       => 'wcrcss-' . $id,
+                        'title'    => $label,
                         'callback' => __NAMESPACE__ . '\render_contextual_help_tabs',
                 ) );