Changeset 5131

Timestamp:

03/08/2017 07:31:45 PM (10 years ago)

Author:

iandunn

Message:

Official WordPress Events: Add more logging to troubleshoot cron bug

After r5017, the jobs ran successfully for a week. When I removed the unintentional wp_die() in r5112, the jobs started getting stuck again. The log shows it getting stuck in the get_meetup_group_ids() and get_meetup_events() loops, so I'm adding more logging here to get insight into that.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php

@@ -418 +418 @@
 
                         while ( '' !== $request_url ) {
+                                $this->log( 'fetching more events from: ' . var_export( $request_url, true ) );
+
                                 $response = $this->remote_get( $request_url );
                                 $body     = json_decode( wp_remote_retrieve_body( $response ) );
 
-                                $this->log( 'fetching more events' );
+                                $this->log( 'pruned response - ' . print_r( $this->prune_response_for_log( $response ), true ) );
 
                                 if ( ! empty ( $body->results ) ) {
@@ -498 +500 @@
 
                 while ( '' !== $request_url ) {
-                        $this->log( 'fetching more groups' );
+                        $this->log( 'fetching more groups from: ' . var_export( $request_url, true ) );
 
                         $response = $this->remote_get( $request_url );
                         $body     = json_decode( wp_remote_retrieve_body( $response ) );
+
+                        $this->log( 'pruned response - ' . print_r( $this->prune_response_for_log( $response ), true ) );
 
                         if ( ! empty ( $body->results ) ) {
@@ -689 +693 @@
          * To avoid storing too much data, the log is reset during each run, and only $limit rows are stored
          *
+         * @todo Remove this when the stuck cron job bug is fixed
+         *
          * @param string $message
          */
@@ -718 +724 @@
                 update_option( 'owpe_log', $this->log, false );
         }
+
+        /**
+         * Prune an HTTP response so the relevant data can be logged for troubleshooting
+         *
+         * @todo Remove this when the stuck cron job bug is fixed
+         *
+         * @param WP_HTTP_Response $response
+         *
+         * @return array
+         */
+        protected function prune_response_for_log( $response ) {
+                $pruned_response = (array) $response;
+
+                if ( isset( $pruned_response['body'] ) ) {
+                        $pruned_response['original_body_meta'] = sprintf(
+                                'type: %s / length: %s',
+                                gettype( $pruned_response['body'] ),
+                                is_string( $pruned_response['body'] ) ? strlen( $pruned_response['body'] ) : 'not a string'
+                        );
+                        $pruned_response['body'] = (array) json_decode( $pruned_response['body'] );
+
+                        if ( isset( $pruned_response['body']['results'] ) ) {
+                                $pruned_response['body']['results'] = 'pruned';
+                        }
+                }
+
+                if ( isset( $pruned_response['http_response'] ) ) {
+                        unset( $pruned_response['http_response'] );
+                }
+
+                if ( isset( $pruned_response['cookies'] ) ) {
+                        unset( $pruned_response['cookies'] );
+                }
+
+                if ( isset( $pruned_response['filename'] ) ) {
+                        unset( $pruned_response['filename'] );
+                }
+
+                return $pruned_response;
+        }
 }