Changeset 5133

Timestamp:

03/08/2017 08:14:09 PM (8 years ago)

Author:

coffee2code

Message:

Credits API: Return 'version' value that matches the data being returned.

For invalid version requests (e.g. something pre-3.2 or post-WP_CORE_STABLE_BRANCH), the Credits API returns data for WP_CORE_STABLE_BRANCH. In such cases the 'version' value in the response was the invalid version being requested.

The returned 'version' should instead reflect the version that matches the data. API consumers can compare their requested version to the response version to see if the fallback (current stable) is being returned.

Props markoheijnen.
Fixes #577.

File:

• sites/trunk/api.wordpress.org/public_html/core/credits/wp-credits.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/core/credits/wp-credits.php

@@ -62 +62 @@
                 require_once $file;
                 $class = 'WP_' . $branch . '_Credits';
-                $credits = new $class( $version, $gp_locale );
+                $credits = new $class( WP_CORE_STABLE_BRANCH, $gp_locale );
                 return $credits;
             }