Changeset 5144

Timestamp:

03/10/2017 08:00:42 PM (8 years ago)

Author:

iandunn

Message:

Official WordPress Events: Lossen loop condition to prevent infinite loop

The extra logging added in r5131 revealed that $request_url was null. It used to be an empty string, and still appears that way in the Meetup.com API console, but something must have changed. There were two changes to json_decode() in PHP 7.x which are related to empty strings and null, so that may have been the cause.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php

@@ -417 +417 @@
             );
 
-            while ( '' !== $request_url ) {
+            while ( ! empty( $request_url ) ) {
                 $this->log( 'fetching more events from: ' . var_export( $request_url, true ) );
 
@@ -499 +499 @@
         );
 
-        while ( '' !== $request_url ) {
+        while ( ! empty( $request_url ) ) {
             $this->log( 'fetching more groups from: ' . var_export( $request_url, true ) );