Changeset 5155 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php

Timestamp:

03/21/2017 05:11:07 PM (9 years ago)

Author:

iandunn

Message:

WordCamp Site Cloner: Remove start date clause so schedule camps are included

That WHERE clause was intentionally excluding camps that hadn't been finished for at least a month, under the assumption that they wouldn't have finished designs. That's a flawed assumption, though, because designs are typically finished by the time the site launches publicly, which is often ~6 months before the camps starts.

Additionally, get_filtered_wordcamp_sites() is already filtering out sites that have the Coming Soon plugin enabled, which achieves that goal in a much more accurate way.

See ​https://wordpress.slack.com/archives/meta-wordcamp/p1490051905939589

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php

@@ -194 +194 @@
 
     // Keep the cache longer than needed, just to be sure that it doesn't expire before the cron job runs again
+    // todo This shouldn't be a transient, it should just be a regular option.
+    //      Transients aren't guaranteed to exist until they expire, so it could expire before the next cron runs
     set_site_transient( WORDCAMP_SITES_TRANSIENT_KEY, get_wordcamp_sites(), DAY_IN_SECONDS * 2 );
 }
@@ -229 +231 @@
         'orderby'        => 'meta_value_num',
         'order'          => 'DESC',
-
-        'meta_query' => array(
-            array(
-                // New sites won't have finished designs, so ignore them
-                'key'     => 'Start Date (YYYY-mm-dd)',
-                'value'   => strtotime( 'now - 1 month' ),
-                'compare' => '<'
-            )
-        ),
     ) );