Changeset 5171

Timestamp:

03/27/2017 07:38:55 PM (7 years ago)

Author:

coffee2code

Message:

Support Forums: Honor i18n number formatting when displaying numbers.

Fixes #1882.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php

@@ -44 +44 @@
         add_action( 'bbp_new_reply',  array( $this, 'handle_extra_reply_actions' ), 10, 2 );
         add_action( 'bbp_edit_reply', array( $this, 'handle_extra_reply_actions' ), 10, 2 );
+
+        // Honor i18n number formatting.
+        add_filter( 'bbp_number_format', array( $this, 'number_format_i18n' ), 10, 5 );
 
         // Store moderator's username on approve/unapprove actions.
@@ -326 +329 @@
 
     /**
+     * Override `bbp_number_format()` to behave like `bbp_number_format_i18n()` under default conditions.
+     *
+     * bbPress uses `bbp_number_format()` in lots of places for display.
+     *
+     * @param string $formatted_number Formatted number.
+     * @param string $number           Number before formatting.
+     * @param bool   $decimals         Display decimals?
+     * @param int    $dec_point        Decimal point character.
+     * @param int    $thousands_sep    Thousands separator character.
+     * @return string
+     */
+    public function number_format_i18n( $formatted_number, $number, $decimals, $dec_point, $thousands_sep ) {
+        // Format number for i18n unless non-default decimal point or thousands separator provided.
+        if ( '.' === $dec_point && ',' === $thousands_sep ) {
+            $formatted_number = bbp_number_format_i18n( $number, $decimals );
+        }
+
+        return $formatted_number;
+    }
+    
+    /**
      * Store moderator's username on approve/unapprove actions.
      *