Changeset 5176

Timestamp:

03/28/2017 01:13:16 AM (9 years ago)

Author:

dd32

Message:

Plugin Directory: Don't overescape the asset URLs, in some places the asset URL was being used where it should not have output-escaping aplied to it which caused extra query args to be discarded.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• class-template.php (modified) (1 diff)
• shortcodes/class-screenshots.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -396 +396 @@
         }
 
-        return esc_url( $url );
+        return esc_url_raw( $url );
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-screenshots.php

@@ -32 +32 @@
         foreach ( $screen_shots as $image ) {
             $screen_shot = sprintf( '<a href="%1$s" rel="nofollow"><img class="screenshot" src="%1$s" alt="" /></a>',
-                Template::get_asset_url( $plugin, $image )
+                esc_url( Template::get_asset_url( $plugin, $image ) )
             );