Changeset 5193

Timestamp:

03/29/2017 01:25:18 PM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Don't show the Remove/Add new committer items for users who cannot manage committers.
Contributors to a plugin (as defined by the readme.txt) have access to the plugins "admin" (in addition to extra support forum capabilities) but can't manage committers, so showing the action links is pointless.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php

@@ -55 +55 @@
                         <?php echo Template::encode( $committer->display_name ); ?>
                     </a><br>
+
+                    <?php if ( current_user_can( 'plugin_remove_committer', $post ) ) : ?>
                     <small>
                         <?php echo current_user_can( 'plugin_review' ) ? esc_html( $committer->user_email ) . ' ' : ''; ?>
                         <button class="button-link remove"><?php _e( 'Remove', 'wporg-plugins' ); ?></button>
                     </small>
+                    <?php else: // This is a hack to avoid doing CSS to make the rows not stack badly. someone fix this please. ?>
+                        <br>
+                    <?php endif; ?>
                 </li>
             <?php endforeach; ?>
 
+            <?php if ( current_user_can( 'plugin_add_committer', $post ) ) : ?>
             <li class="new">
                 <form id="add-committer" action="POST">
@@ -68 +74 @@
                 </form>
             </li>
+            <?php endif; ?>
         </ul>
         <script id="tmpl-new-committer" type="text/template">