Changeset 5211

Timestamp:

03/30/2017 07:25:52 PM (8 years ago)

Author:

Otto42

Message:

Plugin Directory: Handle redirects for clients that send the URL fragment back to the server after a redirect. Redirect such clients to the URL without the fragment. Fixes #2630.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -445 +445 @@
         add_rewrite_rule( '^([^/]+)/(installation|faq|screenshots|changelog|stats|developers|other_notes)/?$', 'index.php?redirect_plugin=$matches[1]&redirect_plugin_tab=$matches[2]', 'top' );
 
+        // Handle redirects for broken clients that send #'s to the server
+        add_rewrite_rule( '^([^/]+)/\#(installation|faq|screenshots|changelog|stats|developers|other_notes)/?$', 'index.php?redirect_plugin=$matches[1]', 'top' );
+
         // If changing capabilities around, uncomment this.
         //Capabilities::add_roles();
@@ -1016 +1019 @@
         if ( get_query_var( 'redirect_plugin' ) && get_query_var( 'redirect_plugin_tab' ) ) {
             wp_safe_redirect( site_url( get_query_var( 'redirect_plugin' ) . '/#' . get_query_var( 'redirect_plugin_tab' ) ) );
+            die();
+        }
+    
+        // Handle a redirect for /$plugin/#$tab_name to just /$plugin/, because some clients don't like fragments in redirects
+        if ( get_query_var( 'redirect_plugin' ) ) {
+            wp_safe_redirect( site_url( get_query_var( 'redirect_plugin' ) . '/' ) );
             die();
         }