Changeset 5217 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

Timestamp:

03/30/2017 09:42:37 PM (8 years ago)

Author:

Otto42

Message:

Plugin Directory: Instead of redirecting for clients that give a URL fragment, simply serve the plugin without a redirect. This is because sending a redirect to the plugin will end up in a redirect loop which is cached. Sending the actual content, which we have and know will prevent this loop.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -445 +445 @@
         add_rewrite_rule( '^([^/]+)/(installation|faq|screenshots|changelog|stats|developers|other_notes)/?$', 'index.php?redirect_plugin=$matches[1]&redirect_plugin_tab=$matches[2]', 'top' );
 
-        // Handle redirects for broken clients that send #'s to the server
-        add_rewrite_rule( '^([^/]+)/\#(.*)/?$', 'index.php?redirect_plugin=$matches[1]', 'top' );
+        // Handle content for broken clients that send #'s to the server
+        add_rewrite_rule( '^([^/]+)/\#(.*)/?$', 'index.php?name=$matches[1]', 'top' );
 
         // If changing capabilities around, uncomment this.
@@ -1022 +1022 @@
         }
     
-        // Handle a redirect for /$plugin/#$tab_name to just /$plugin/, because some clients don't like fragments in redirects
-        if ( get_query_var( 'redirect_plugin' ) ) {
-            wp_safe_redirect( site_url( get_query_var( 'redirect_plugin' ) . '/' ) );
-            die();
-        }
-
         // We've disabled WordPress's default 404 redirects, so we'll handle them ourselves.
         if ( is_404() ) {