Changeset 5223

Timestamp:

03/30/2017 11:01:40 PM (8 years ago)

Author:

iandunn

Message:

WordCamp Helpers: Remove trailing slash from partial endpoint path

If the path ended in a /, like with /wp-json/wp/v2/sessions/, and then a client visits the unslashed endpoint URL (e.g., ​https://2016.seattle.wordcamp.org/wp-json/wp/v2/sessions), then the function would return early and the fields would not be registered.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helper-functions.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helper-functions.php

@@ -322 +322 @@
  * @param array  $meta_fields An array index by the field slug, with values to be passed to `register_meta()` as
  *                            `$args`. For example, `array( '_wcpt_session_slides' => array( 'single' => true ) )`
- * @param string $endpoint    The full path of the endpoint. For example, '/wp-json/wp/v2/sessions/'
+ * @param string $endpoint    The partial path of the endpoint. For example, '/wp-json/wp/v2/sessions'.
  */
 function wcorg_register_meta_only_on_endpoint( $meta_type, $meta_fields, $endpoint ) {
-    $is_correct_endpoint_request = false !== strpos( $_SERVER['REQUEST_URI'], $endpoint );
+    $is_correct_endpoint_request = false !== strpos( $_SERVER['REQUEST_URI'], untrailingslashit( $endpoint ) );
 
     if ( ! $is_correct_endpoint_request ) {