Changeset 5236

Timestamp:

04/04/2017 08:44:06 AM (7 years ago)

Author:

dd32

Message:

Plugin Directory: Update API: Fix a bug in the update api updater which would cause new plugins not to get a row added to the version lookup table for the update api.
This also removes the ability for a plugin in approved state from being inserted, just to limit the size of the table from the thousands of approved-but-not-uploaded plugins.

See #2112

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php

@@ -24 +24 @@
                 p.post_type = 'plugin'
                 AND (
-                    p.post_status IN( 'publish', 'approved', 'disabled', 'closed' ) OR
+                    p.post_status IN( 'publish', 'disabled', 'closed' ) OR
                     u.plugin_id IS NOT NULL
                 )
@@ -56 +56 @@
         $post = Plugin_Directory::get_plugin_post( $plugin_slug );
 
-        if ( ! $post ) {
+        if ( ! $post || ! in_array( $post->post_status, array( 'publish', 'disabled', 'closed' ) ) ) {
             $wpdb->delete(  $wpdb->prefix . 'update_source', compact( 'plugin_slug' ) );
             return true;
@@ -80 +80 @@
 
         if (
-            $wpdb->update( $wpdb->prefix . 'update_source', $data, array( 'plugin_slug' => $post->post_name ) ) &&
+            ! $wpdb->update( $wpdb->prefix . 'update_source', $data, array( 'plugin_slug' => $post->post_name ) ) &&
             ! $wpdb->get_var( $wpdb->prepare( "SELECT `plugin_slug` FROM `{$wpdb->prefix}update_source` WHERE `plugin_slug` = %s", $post->post_name ) )
         ) {