Making WordPress.org

Changeset 5239


Ignore:
Timestamp:
04/04/2017 05:45:12 PM (8 years ago)
Author:
coffee2code
Message:

developer.wordpress.org: Improve organization of the user contributed note submission area.

  • Move some writing-related prefatory text into list above comment textarea
  • Leave remaining submit-related text below comment textarea, but formatted as a list
  • Add button-like styles around the code buttons text
  • Minor string tweaks
  • Ensure autoscroll goes to top of prefatory text and not just to the textarea

Props DrewAPicture.
Fixes #1905.

Location:
sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/comments.php

    r3852 r5239  
    6868            'class_form'          => 'comment-form tab-container',
    6969            'comment_field'       => DevHub_User_Submitted_Content::wp_editor_comments(),
    70             'comment_notes_after' => DevHub_Note_Preview::comment_preview() .
    71                 '<p>' .
    72                 __( 'Notes should supplement code reference entries, for example examples, tips, explanations, use-cases, and best practices.', 'wporg' ) .
    73                 '</p><p>' .
    74                 __( 'Feedback can be to report errors or omissions with the documentation on this page. Such feedback will not be publicly posted.', 'wporg' ) .
    75                 '</p><p>' .
    76                 __( 'Do not use this form for support requests, discussions, spam, bug reports, complaints, or self-promotion. Entries of this nature will be deleted.', 'wporg' ) .
    77                 '</p><p>' .
    78                 __( 'You can enter text and code. Use the php, js, or inline code buttons to wrap code snippets.', 'wporg' ) .
    79                 '</p><p>' .
    80                 __( 'In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key. In some cases the Esc key will need to be pressed twice before the Tab key will allow you to continue.', 'wporg' ) .
    81                 '</p><p class="user-notes-are-gpl">' .
    82                 sprintf( __( '<strong>NOTE:</strong> All contributions are licensed under <a href="%s">GFDL</a> and are moderated before appearing on the site.', 'wporg' ), 'https://gnu.org/licenses/fdl.html' ) .
    83                 '</p>',
     70            'logged_in_as'        => '<p class="logged-in-as">'
     71                . sprintf(
     72                    /* translators: 1: user profile link, 2: accessibility text, 3: user name, 4: logout URL */
     73                    __( '<a href="%1$s" aria-label="%2$s">Logged in as %3$s</a>. <a href="%4$s">Log out?</a>' ),
     74                    'https://profiles.wordpress.org/' . esc_attr( wp_get_current_user()->user_nicename ),
     75                    /* translators: %s: user name */
     76                    esc_attr( sprintf( __( 'Logged in as %s. Edit your profile.' ), $user_identity ) ),
     77                    $user_identity,
     78                    wp_logout_url( apply_filters( 'the_permalink', get_permalink() ) )
     79                )
     80                . '</p><p><ul><li>'
     81                . __( 'Notes should supplement code reference entries, for example examples, tips, explanations, use-cases, and best practices.', 'wporg' )
     82                . '</li><li>'
     83                . __( 'Feedback can be to report errors or omissions with the documentation on this page. Such feedback will not be publicly posted.', 'wporg' )
     84                . '</li><li>'
     85                /* translators: 1: php button, 2: js button, 3: inline code button */
     86                . sprintf(
     87                    __( 'You can enter text and code. Use the %1$s, %2$s, or %3$s buttons to wrap code snippets.', 'wporg' ),
     88                    '<span class="text-button">php</span>',
     89                    '<span class="text-button">js</span>',
     90                    '<span class="text-button">' . __( 'inline code', 'wporg' ) . '</span>'
     91                )
     92                . '</li></ul></p>',
     93            'comment_notes_after' => DevHub_Note_Preview::comment_preview()
     94                . '<p>'
     95                . __( 'Submission Notes:', 'wporg' )
     96                . '<ul><li>'
     97                . __( 'This form is not for support requests, discussions, spam, bug reports, complaints, or self-promotion. Entries of this nature will be deleted.', 'wporg' )
     98                . '</li><li>'
     99                . __( 'In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key. In some cases the Esc key will need to be pressed twice before the Tab key will allow you to continue.', 'wporg' )
     100                . '</li><li class="user-notes-are-gpl">'
     101                . sprintf(
     102                    /* translators: 1: GFDL link */
     103                    __( '<strong>NOTE:</strong> All contributions are licensed under %s and are moderated before appearing on the site.', 'wporg' ),
     104                    '<a href="https://gnu.org/licenses/fdl.html">GFDL</a>'
     105                )
     106                . '</li></ul></p>',
    84107            'label_submit'        => __( 'Add Note or Feedback', 'wporg' ),
    85108            'must_log_in'         => '<p>' . sprintf(
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/user-notes.js

    r3852 r5239  
    1616        $( '#add-user-note').hide();
    1717
    18         var target = $( '#commentform #add-note-or-feedback' );
     18        var target = $( '#commentform' );
    1919        if ( target.length ) {
    2020            var pos = target.offset();
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/main.scss

    r4985 r5239  
    14351435            font-size: 1.6rem;
    14361436        }
     1437
     1438        .text-button {
     1439            background: #fff none repeat scroll 0 0;
     1440            border-color: #ccc #ccc #bbb;
     1441            border-radius: 3px;
     1442            border-style: solid;
     1443            border-width: 1px;
     1444            padding: 0 5px;
     1445        }
     1446
     1447        .comment-form ul {
     1448            margin-left: 1.5em;
     1449        }
    14371450    }
    14381451
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/main.css

    r4985 r5239  
    18221822}
    18231823
     1824.devhub-wrap.single-wp-parser-function .text-button, .devhub-wrap.single-wp-parser-method .text-button, .devhub-wrap.single-wp-parser-hook .text-button, .devhub-wrap.single-wp-parser-class .text-button {
     1825  background: #fff none repeat scroll 0 0;
     1826  border-color: #ccc #ccc #bbb;
     1827  border-radius: 3px;
     1828  border-style: solid;
     1829  border-width: 1px;
     1830  padding: 0 5px;
     1831}
     1832
     1833.devhub-wrap.single-wp-parser-function .comment-form ul, .devhub-wrap.single-wp-parser-method .comment-form ul, .devhub-wrap.single-wp-parser-hook .comment-form ul, .devhub-wrap.single-wp-parser-class .comment-form ul {
     1834  margin-left: 1.5em;
     1835}
     1836
    18241837.devhub-wrap.single-post .comment-list,
    18251838.devhub-wrap.single-post .comment-list ol {
Note: See TracChangeset for help on using the changeset viewer.