Changeset 5244

Timestamp:

04/05/2017 01:14:12 AM (8 years ago)

Author:

obenland

Message:

Plugin Directory: Make entire question clickable.

Also simplifies JS callback and removes the need to mess with focus styles.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/js/section-faq.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/js/section-faq.js

@@ -7 +7 @@
             $question.html( $button.text( $question.text() ) );
         } )
-        .on( 'mousedown keydown', '.button-link', function( event ) {
-            var $question = $( event.target );
+        .on( 'click', function( event ) {
+            var $question = $( event.currentTarget );
 
             if ( 'keydown' === event.type && 13 !== event.which ) {
@@ -14 +14 @@
             }
 
-            $question.toggleClass( 'no-focus', 'mousedown' === event.type );
-
             if ( ! $question.is( '.open' ) ) {
-                $question.siblings( '.open' ).toggleClass( 'open' ).attr( 'aria-expanded', false ).parent().next( 'dd' ).slideToggle( 200 );
+                $question.siblings( '.open' ).toggleClass( 'open' ).attr( 'aria-expanded', false ).next( 'dd' ).slideToggle( 200 );
             }
 
-            $question.parent().toggleClass( 'open' ).attr( 'aria-expanded', function( index, attribute ) {
+            $question.toggleClass( 'open' ).attr( 'aria-expanded', function( index, attribute ) {
                 return 'true' !== attribute;
             } ).next( 'dd' ).slideToggle( 200 );