Changeset 5286

Timestamp:

04/07/2017 09:16:09 PM (8 years ago)

Author:

coffee2code

Message:

Support Forums: Update to query against the new Plugin Directory WP tables.

Updates get_object_by_slug_and_type(), get_authors(), get_contributors(), get_plugin_slugs_by_committer(), get_plugin_slugs_by_contributor().

Fixes #2701.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc

Files:

• class-directory-compat.php (modified) (3 diffs)
• class-support-compat.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -816 +816 @@
                 $compat_object = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->base_prefix}%d_posts WHERE post_name = %s AND post_type = 'repopackage' LIMIT 1", WPORG_THEME_DIRECTORY_BLOGID, $slug ) );
             } elseif ( $type == 'plugin' ) {
-                // @todo Update this when the Plugin Directory switches over to WordPress.
-                $_compat_topic = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM " . PLUGINS_TABLE_PREFIX . "topics WHERE topic_slug = %s", $slug ) );
-                if ( $_compat_topic ) {
-                    $_compat_post  = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM " . PLUGINS_TABLE_PREFIX . "posts WHERE topic_id = %d AND post_position = 1 LIMIT 1", $_compat_topic->topic_id ) );
-                }
-                if ( $_compat_topic && $_compat_post ) {
-                    $compat_object = (object) array(
-                        'post_title'   => $_compat_topic->topic_title,
-                        'post_name'    => $slug,
-                        'post_author'  => $_compat_topic->topic_poster,
-                        'post_content' => $_compat_post->post_text,
-                    );
-                }
+                $compat_object = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->base_prefix}%d_posts WHERE post_name = %s AND post_type = 'plugin' LIMIT 1", WPORG_PLUGIN_DIRECTORY_BLOGID, $slug ) );
             }
 
@@ -854 +842 @@
                 $authors = array( $author->user_login );
             } else {
-                $authors = $wpdb->get_col( $wpdb->prepare( " SELECT user FROM " . PLUGINS_TABLE_PREFIX . "svn_access WHERE `path` = %s", '/' . $slug ) );
+                $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+                // Note: Intentionally not considering posts of 'plugin' post_type with
+                // 'post_author' matching this author because the field only relates to
+                // the user who submitted the plugin. It does not confer special access,
+                // rights, or ownership.
+                $authors = $wpdb->get_col( $wpdb->prepare(
+                    "SELECT slug
+                     FROM {$prefix}terms AS t
+                     LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+                     LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id 
+                     WHERE tt.taxonomy = 'plugin_committers' AND tr.object_id = %d",
+                     $this->plugin->ID
+                ) );
             }
 
@@ -880 +880 @@
         $contributors = wp_cache_get( $cache_key, $cache_group );
         if ( false === $contributors ) {
-            // @todo Update this when the Plugin Directory switches over to WordPress.
-            $contributors = $wpdb->get_var( $wpdb->prepare(
-                "SELECT meta_value FROM " . PLUGINS_TABLE_PREFIX . "meta m LEFT JOIN " . PLUGINS_TABLE_PREFIX . "topics t ON m.object_id = t.topic_id WHERE t.topic_slug = %s AND m.object_type = %s AND m.meta_key = %s",
-                $slug, 'bb_topic', 'contributors' ) );
-            if ( $contributors ) {
-                $contributors = unserialize( $contributors );
-            }
+            $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+            $contributors = $wpdb->get_col( $wpdb->prepare(
+                "SELECT slug
+                 FROM {$prefix}terms AS t
+                 LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+                 LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id 
+                 WHERE tt.taxonomy = 'plugin_contributors' AND tr.object_id = %d",
+                 $this->plugin->ID
+            ) );
 
             wp_cache_set( $cache_key, $contributors, $cache_group, HOUR_IN_SECONDS );

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-support-compat.php

@@ -133 +133 @@
                         'taxonomy'    => 'topic-plugin',
                         'field'       => 'slug',
-                        'terms'       => self::get_plugin_slugs_by_committer( $this->user->user_login ),
+                        'terms'       => self::get_plugin_slugs_by_committer( $this->user->user_nicename ),
                     ) ),
                     'show_stickies'   => false,
@@ -145 +145 @@
                         'taxonomy'    => 'topic-plugin',
                         'field'       => 'slug',
-                        'terms'       => $this->get_plugin_slugs_by_contributor( $this->user ),
+                        'terms'       => $this->get_plugin_slugs_by_contributor( $this->user->user_nicename ),
                     ) ),
                     'show_stickies'   => false,
@@ -168 +168 @@
         if ( $view == 'plugin-committer' ) {
 
-            $slugs = self::get_plugin_slugs_by_committer( $this->user->user_login );
+            $slugs = self::get_plugin_slugs_by_committer( $this->user->user_nicename );
 
             // Add plugin-committer view.
@@ -191 +191 @@
         } elseif ( $view == 'plugin-contributor' ) {
 
-            $slugs = self::get_plugin_slugs_by_contributor( $this->user );
+            $slugs = self::get_plugin_slugs_by_contributor( $this->user->user_nicename );
 
             // Add plugin-contributor view.
@@ -453 +453 @@
     }
 
-    public static function get_plugin_slugs_by_committer( $user_login ) {
+    public static function get_plugin_slugs_by_committer( $user_nicename ) {
         global $wpdb;
-        $slugs = (array) $wpdb->get_col( $wpdb->prepare( "SELECT `path` FROM `" . PLUGINS_TABLE_PREFIX . "svn_access` WHERE `user` = %s AND `access` = 'rw'", $user_login ) );
-        return self::clean_slugs( $slugs );
-    }
-
-    public static function get_plugin_slugs_by_contributor( $user ) {
+
+        $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+        $slugs = $wpdb->get_col( $wpdb->prepare(
+            "SELECT post_name
+             FROM {$prefix}posts AS p
+             LEFT JOIN {$prefix}term_relationships AS tr ON p.ID = tr.object_id
+             LEFT JOIN {$prefix}term_taxonomy AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id 
+             LEFT JOIN {$prefix}terms AS t ON tt.term_id = t.term_id
+             WHERE tt.taxonomy = 'plugin_committers' AND p.post_status = 'publish' AND p.post_type = 'plugin' AND t.slug = %s
+             ORDER BY p.post_title ASC",
+            $user_nicename
+        ) );
+
+        return $slugs;
+    }
+
+    public static function get_plugin_slugs_by_contributor( $user_nicename ) {
         global $wpdb;
-        $slugs = (array) $wpdb->get_col( $wpdb->prepare( "SELECT `topic_slug` FROM `" . PLUGINS_TABLE_PREFIX . "topics` WHERE `topic_poster` = %d AND topic_open = 1 AND topic_status = 0", $user->ID ) );
-        $slugs = self::clean_slugs( $slugs );
-        if ( $contributor = $wpdb->get_col( $wpdb->prepare( "SELECT `object_id` FROM `" . PLUGINS_TABLE_PREFIX . "meta` WHERE `object_type` = 'bb_topic' AND `meta_key` = 'contributors' AND `meta_value` LIKE %s", '%"' . str_replace( array( '%', '_' ), array( '\\%', '\\_' ), $user->user_login ) . '"%' ) ) ) {
-            if ( $contributor_slugs = $wpdb->get_col( "SELECT `topic_slug` FROM `" . PLUGINS_TABLE_PREFIX . "topics` WHERE `topic_id` IN (" . join( ',', $contributor ) . ") AND topic_open = 1 AND topic_status = 0" ) ) {
-                $slugs = array_unique( array_merge( $slugs, $contributor_slugs ) );
-            }
-        }
+
+        $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+        $slugs = $wpdb->get_col( $wpdb->prepare(
+            "SELECT post_name
+             FROM {$prefix}posts AS p
+             LEFT JOIN {$prefix}term_relationships AS tr ON p.ID = tr.object_id
+             LEFT JOIN {$prefix}term_taxonomy AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id 
+             LEFT JOIN {$prefix}terms AS t ON tt.term_id = t.term_id
+             WHERE tt.taxonomy = 'plugin_contributors' AND p.post_status = 'publish' AND p.post_type = 'plugin' AND t.slug = %s
+             ORDER BY p.post_title ASC",
+            $user_nicename
+        ) );
+
         return $slugs;
     }