Changeset 5308

Timestamp:

04/10/2017 08:00:18 PM (8 years ago)

Author:

ocean90

Message:

Plugin Directory: Link internal notes to the edit post screen.

Fixes #2667.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/class-customizations.php (modified) (3 diffs)
• js/edit-form.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -40 +40 @@
         add_action( 'wp_ajax_replyto-comment', array( $this, 'save_custom_comment' ), 0 );
         add_filter( 'comment_row_actions', array( $this, 'custom_comment_row_actions' ), 10, 2 );
+        add_filter( 'get_comment_link', array( $this, 'link_internal_notes_to_admin' ), 10, 2 );
 
         // Admin Metaboxes
@@ -109 +110 @@
                 case 'post.php':
                     wp_enqueue_style( 'plugin-admin-post-css', plugins_url( 'css/edit-form.css', Plugin_Directory\PLUGIN_FILE ), array( 'edit' ), 4 );
-                    wp_enqueue_script( 'plugin-admin-post-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 1 );
+                    wp_enqueue_script( 'plugin-admin-post-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 2 );
                     wp_localize_script( 'plugin-admin-post-js', 'pluginDirectory', array(
                         'removeCommitterAYS' => __( 'Are you sure you want to remove this committer?', 'wporg-plugins' ),
@@ -411 +412 @@
 
         return $actions;
+    }
+
+    /**
+     * Changes the permalink for internal notes to link to the edit post screen.
+     *
+     * @param string $link The comment permalink with '#comment-$id' appended.
+     * @param \WP_Comment $comment The current comment object.
+     * @return string The permalink to the given comment.
+     */
+    public function link_internal_notes_to_admin( $link, $comment ) {
+        if ( 'internal-note' === $comment->comment_type ) {
+            $link = get_edit_post_link( $comment->comment_post_ID );
+            $link = $link . '#comment-' . $comment->comment_ID;
+        }
+
+        return $link;
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/js/edit-form.js

@@ -99 +99 @@
 
                     $( 'a[className*=\':\']' ).unbind();
+
+                    if ( 0 === location.hash.indexOf( '#comment-' ) ) {
+                        $( document.body ).animate( { scrollTop: $( location.hash ).offset().top - 100 }, 100 );
+                    }
                 }
             } );