Changeset 5318 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

Timestamp:

04/11/2017 06:37:04 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Introduce the 'new' post_status to replace 'draft', this will allow a better more well-defined statuses for plugins.

See #2716

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

@@ -11 +11 @@
         $post = get_post();
 
-        $zip_url = '';
+        $zip_files = array();
         foreach ( get_attached_media( 'application/zip', $post ) as $zip_file ) {
-            $zip_url = wp_get_attachment_url( $zip_file->ID );
-            break;
+            $zip_files[ $zip_file->post_date ] = wp_get_attachment_url( $zip_file->ID );
         }
-        if ( ! $zip_url ) {
-            $zip_url = get_post_meta( $post->ID, '_submitted_zip', true );
+        uksort( $zip_files, function( $a, $b ) {
+            return strtotime( $a ) < strtotime( $b );
+        } );
+
+        if ( $zip_url = get_post_meta( $post->ID, '_submitted_zip', true ) ) {
+            // Back-compat only.
+            $zip_files[ 'User provided URL' ] = $zip_url;
         }
 
-        if ( $zip_url ) {
+        foreach ( $zip_files as $zip_date => $zip_url ) {
             printf( '<p>' . __( '<strong>Zip file:</strong> %s', 'wporg-plugins' ) . '</p>',
-                sprintf( '<a href="%s">%s</a>', esc_url( $zip_url ), esc_html( $zip_url ) )
+                sprintf( '%s <a href="%s">%s</a>', esc_html( $zip_date ), esc_url( $zip_url ), esc_html( $zip_url ) )
             );
         }
 
-        if ( 'pending' != $post->post_status ) {
+        if ( 'pending' != $post->post_status && 'new' != $post->post_status ) {
             echo "<ul>
                 <li><a href='https://plugins.trac.wordpress.org/log/{$post->post_name}/'>" . __( 'Development Log', 'wporg-plugins' ) . "</a></li>
@@ -33 +37 @@
             </ul>';
         }
-        if ( $post->post_excerpt && in_array( $post->post_status, array( 'pending', 'approved' ) ) ) {
+        if ( $post->post_excerpt && in_array( $post->post_status, array( 'new', 'pending', 'approved' ) ) ) {
             echo '<p>' . strip_tags( $post->post_excerpt ) . '</p>';
         }
@@ -41 +45 @@
             
             $type   = 'Notice';
-            if ( $post->post_status == 'draft' || $post->post_status == 'pending' ) {
+            if ( $post->post_status == 'new' || $post->post_status == 'pending' ) {
                 $type = 'Request';
             }