Changeset 5331

Timestamp:

04/14/2017 07:28:11 PM (9 years ago)

Author:

Otto42

Message:

Plugin Directory: Readme Validator, add output of some kind on success. May need additional styling. See #2705.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php

@@ -53 +53 @@
                 }
 
+                $output = '';
+
                 $error_types = array(
                         'errors'   => __( 'Fatal Errors:', 'wporg-plugins' ),
@@ -60 +62 @@
                 foreach ( $error_types as $field => $warning_label ) {
                         if ( !empty( $errors[ $field ] ) ) {
-                                echo "{$warning_label}\n<ul class='{$field} error'>\n";
+                                $output .= "{$warning_label}\n<ul class='{$field} error'>\n";
                                 foreach ( $errors[ $field ] as $notice ) {
-                                        echo "<li>{$notice}</li>\n";
+                                        $output .= "<li>{$notice}</li>\n";
                                 }
-                                echo "</ul>\n";
+                                $output .= "</ul>\n";
                         }
                 }
+
+                if ( empty( $output ) ) {
+                        $output = __( 'No errors detected in the readme.txt file.', 'wporg-plugins' );
+                }
+
+                echo $output;
         }
 }