Changeset 5338 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

Timestamp:

04/15/2017 10:47:44 AM (7 years ago)

Author:

Otto42

Message:

Plugin Directory: Import script should set post modified time if existing time is not set. This prevents a 2019 years ago condition which is caused by plugins being approved and having a version number set for them, but then having that same version be checked into SVN, thus not having a version difference to cause the initial update time to change. Fixes #2740

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -82 +82 @@
         $plugin->post_excerpt = trim( $readme->short_description ) ?: $headers->Description ?: $plugin->post_excerpt;
 
-        // Bump last updated if the version has changed, but only if this isn't a fresh import.
-        if ( !isset( $headers->Version ) || $headers->Version != get_post_meta( $plugin->ID, 'version', true ) ) {
+        // Bump last updated if the version has changed, or if the post_modified is empty (which is the case for many initial checkins).
+        if ( ( !isset( $headers->Version ) || $headers->Version != get_post_meta( $plugin->ID, 'version', true ) ) ||
+             ( $plugin->post_modified == '0000-00-00 00:00:00' ) ) {
             $plugin->post_modified = $plugin->post_modified_gmt = current_time( 'mysql' );
         }