Changeset 5354

Timestamp:

04/17/2017 08:21:23 PM (10 years ago)

Author:

coffee2code

Message:

Plugin Directory, Stats Report: Display 'N/A' instead of '0' for status transition stats that aren't currently tracked.

Prevents '0' from being seen as a meaningful number when it isn't.

Props Ipstenu.
See #2744.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php

@@ -102 +102 @@
                 }
 
+                // Temporary until the above is updated to work with the new directory:
+                foreach ( array( 'plugin_approve', 'plugin_delist', 'plugin_reject' ) as $unused_stat ) {
+                        if ( ! $stats[ $unused_stat ] ) $stats[ $unused_stat ] = __( 'N/A', 'wporg-plugins' );
+                }
+
                 // --------------
                 // Plugin Queue
@@ -238 +243 @@
                 <ul style="font-family:Courier New;">
                         <li><?php printf( __( 'Plugins requested : %d', 'wporg-plugins' ), $stats['plugin_new'] ); ?></li>
-                        <li><?php printf( __( 'Plugins rejected : %d', 'wporg-plugins' ),  $stats['plugin_reject'] ); ?></li>
-                        <li><?php printf( __( 'Plugins closed : %d', 'wporg-plugins' ),    $stats['plugin_delist'] ); ?></li>
-                        <li><?php printf( __( 'Plugins approved : %d', 'wporg-plugins' ),  $stats['plugin_approve'] ); ?></li>
+                        <li><?php printf( __( 'Plugins rejected : %s', 'wporg-plugins' ),  $stats['plugin_reject'] ); ?></li>
+                        <li><?php printf( __( 'Plugins closed : %s', 'wporg-plugins' ),    $stats['plugin_delist'] ); ?></li>
+                        <li><?php printf( __( 'Plugins approved : %s', 'wporg-plugins' ),  $stats['plugin_approve'] ); ?></li>
                 </ul>