Changeset 5445 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

Timestamp:

04/30/2017 04:03:05 PM (9 years ago)

Author:

ocean90

Message:

Plugin Directory: Remove unused global import and use public instead of var for properties.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -22 +22 @@
 
         // Readme fields which get stored in plugin meta
-        var $readme_fields = array(
+        public $readme_fields = array(
                 'tested',
                 'requires',
@@ -29 +29 @@
                 'license_uri',
                 'upgrade_notice',
-                'screenshots'
+                'screenshots',
         );
 
         // Plugin headers that are stored in plugin meta
-        var $plugin_headers = array(
+        public $plugin_headers = array(
                 // Header    => meta_key
                 'Name'       => 'header_name',
@@ -40 +40 @@
                 'Author'     => 'header_author',
                 'AuthorURI'  => 'header_author_uri',
-                'TextDomain' => 'header_textdomain'
+                'TextDomain' => 'header_textdomain',
         );
 
@@ -53 +53 @@
          */
         public function import_from_svn( $plugin_slug, $svn_changed_tags = array( 'trunk' ), $svn_revision_triggered = 0 ) {
-                global $wpdb;
-
                 $plugin = Plugin_Directory::get_plugin_post( $plugin_slug );
                 if ( ! $plugin ) {
-                        throw new Exception( "Unknown Plugin" );
+                        throw new Exception( 'Unknown Plugin' );
                 }
 
@@ -73 +71 @@
                                 $content .= "\n\n<!--section={$section}-->\n{$section_content}";
                         }
-                } elseif ( !empty( $headers->Description ) ) {
+                } elseif ( ! empty( $headers->Description ) ) {
                         $content = "<!--section=description-->\n{$headers->Description}";
                 }