Changeset 5495

Timestamp:

05/17/2017 06:21:49 PM (5 years ago)

Author:

iandunn

Message:

Events: Prefer meetups over WordCamps to improve location accuracy

See #2823

File:

• sites/trunk/api.wordpress.org/public_html/events/1.0/index.php (modified) (2 diffs)

sites/trunk/api.wordpress.org/public_html/events/1.0/index.php

@@ -410 +410 @@
  * See https://meta.trac.wordpress.org/ticket/2823#comment:21
  *
+ * This isn't ideal, since the location it picks is potentially an hour's driving time from the user. If we get a
+ * lot of complaints, we could potentially change this to search the `geonames` database for the name of the city
+ * that was returned by the `ip2location` database. That should be more accurate, but it would require an extra
+ * database lookup, and could potentially fail to return any results.
+ *
  * @param array $events
  *
@@ -422 +427 @@
             $location['description'] = $location['location'];
             unset( $location['location'] );
-            break;
+
+            /*
+             * If the event is a WordCamp, continue searching until a meetup is found. Meetups have a much smaller
+             * search radius in `get_events()`, so they'll be closer to the user's location. Some cities will only
+             * have WordCamps scheduled at the moment, though, so we can fall back to those.
+             */
+            if ( 'meetup' === $event['type'] ) {
+                break;
+            }
         }
     }