Changeset 5502 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-locale.php

Timestamp:

05/21/2017 01:51:02 PM (9 years ago)

Author:

ocean90

Message:

Translate: Avoid PHP notices if a translation set doesn't exist.

Also add a few missing esc_url() calls and a custom 404 template with a link back to the homepage.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-locale.php (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-locale.php

@@ -17 +17 @@
 class Locale extends GP_Route {
 
+    private $cache_group = 'wporg-translate';
+
     /**
      * Adapter for the rosetta roles plugin.
@@ -49 +51 @@
         $locale = GP_Locales::by_slug( $locale_slug );
         if ( ! $locale ) {
+            return $this->die_with_404();
+        }
+
+        if ( ! $this->translation_set_slug_exists( $locale, $set_slug ) ) {
             return $this->die_with_404();
         }
@@ -88 +94 @@
         }
 
-
         $paged_sub_projects = $this->get_paged_active_sub_projects(
             $project,
@@ -136 +141 @@
         $can_create_locale_glossary = GP::$permission->current_user_can( 'admin' );
         $locale_glossary_translation_set = GP::$translation_set->by_project_id_slug_and_locale( 0, $set_slug, $locale_slug );
-        $locale_glossary = GP::$glossary->by_set_id( $locale_glossary_translation_set->id );
+        $locale_glossary = false;
+        if ( $locale_glossary_translation_set ) {
+            $locale_glossary = GP::$glossary->by_set_id( $locale_glossary_translation_set->id );
+        }
 
         $this->tmpl( 'locale-projects', get_defined_vars() );
@@ -152 +160 @@
         $locale = GP_Locales::by_slug( $locale_slug );
         if ( ! $locale ) {
+            return $this->die_with_404();
+        }
+
+        if ( ! $this->translation_set_slug_exists( $locale, $set_slug ) ) {
             return $this->die_with_404();
         }
@@ -198 +210 @@
 
         $this->tmpl( 'locale-project', get_defined_vars() );
+    }
+
+    /**
+     * Whether a translation set slug exists for a locale.
+     *
+     * @param \GP_Locale $locale The locale.
+     * @param string     $slug   The slug of a translation set.
+     * @return bool True if slug exists, false if not.
+     */
+    private function translation_set_slug_exists( $locale, $slug ) {
+        $cache_key = "translation_set_slugs:{$locale->slug}";
+        $slugs = wp_cache_get( $cache_key, $this->cache_group );
+
+        if ( false === $slugs ) {
+            global $wpdb;
+            $slugs = $wpdb->get_col( $wpdb->prepare(
+                "SELECT DISTINCT(slug) FROM {$wpdb->gp_translation_sets} WHERE locale = %s",
+                $locale->slug
+            ) );
+
+            wp_cache_set( $cache_key, $slugs, $this->cache_group, DAY_IN_SECONDS );
+        }
+
+        return in_array( $slug, $slugs, true );
     }