Changeset 5503 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-locale.php

Timestamp:

05/21/2017 02:20:50 PM (9 years ago)

Author:

ocean90

Message:

Translate: Replace query for translation set slugs with a hardcoded list to fix performance issue.

See [5502].

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-locale.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/routes/class-locale.php

@@ -220 +220 @@
      */
     private function translation_set_slug_exists( $locale, $slug ) {
-        $cache_key = "translation_set_slugs:{$locale->slug}";
+        /*$cache_key = "translation_set_slugs:{$locale->slug}";
         $slugs = wp_cache_get( $cache_key, $this->cache_group );
 
@@ -231 +231 @@
 
             wp_cache_set( $cache_key, $slugs, $this->cache_group, DAY_IN_SECONDS );
-        }
-
-        return in_array( $slug, $slugs, true );
+        }*/
+
+        // Hardcoded list because the query above doesn't perform well due to a missing index.
+        $slugs = [
+            'default' => [
+                'default',
+            ],
+            'de' => [
+                'default',
+                'formal',
+            ],
+            'de-ch' => [
+                'default',
+                'informal',
+            ],
+            'nl' => [
+                'default',
+                'formal',
+            ],
+            'pt' => [
+                'default',
+                'informal',
+            ],
+        ];
+
+        if ( isset( $slugs[ $locale->slug ] ) ) {
+            return in_array( $slug, $slugs[ $locale->slug ], true );
+        }
+
+        return in_array( $slug, $slugs['default'], true );
     }