Changeset 5513

Timestamp:

05/24/2017 11:42:00 PM (9 years ago)

Author:

coreymckrill

Message:

WordCamp: Remove non-functional organizer reminder trigger

This removes the wcpt_added_to_planning_schedule action hook (which
was logically unreachable) and associated triggers and callbacks in the
Organizer Reminders plugin. It switches the actions that were hooked to
it over to the new action hook that was created in r5512.

The expected consequence of this change is that some organizer reminder
emails that were previously not getting sent because they were using
unreachable triggers will now be sent again. This change has been vetted
by the Global Community Team.

Props coreymckrill

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins

Files:

• wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (1 diff)
• wordcamp-organizer-reminders/wcor-mailer.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -44 +44 @@
         add_action( 'transition_post_status',                         array( $this, 'trigger_schedule_actions' ), 10, 3 );
         add_action( 'transition_post_status',                         array( $this, 'log_status_changes'       ), 10, 3 );
-        add_action( 'wcpt_added_to_planning_schedule',                array( $this, 'add_organizer_to_central' ), 10 );
-        add_action( 'wcpt_added_to_planning_schedule',                array( $this, 'mark_date_added_to_planning_schedule' ), 10 );
+        add_action( 'wcpt_approved_for_pre_planning',                 array( $this, 'add_organizer_to_central' ), 10 );
+        add_action( 'wcpt_approved_for_pre_planning',                 array( $this, 'mark_date_added_to_planning_schedule' ), 10 );
         add_filter( 'wp_insert_post_data',                            array( $this, 'enforce_post_status' ), 10, 2 );
         add_filter( 'wp_insert_post_data',                            array( $this, 'require_complete_meta_to_publish_wordcamp' ), 11, 2 ); // after enforce_post_status

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php

@@ -19 +19 @@
                         'name'       => 'wcpt_approved_for_pre_planning',
                         'callback'   => 'send_trigger_approved_for_pre_planning',
-                        'priority'   => 10,
-                        'parameters' => 1,
-                    ),
-                ),
-            ),
-
-            'wcor_added_to_pending_schedule' => array(
-                'name'     => 'WordCamp added to pending schedule',
-                'actions'  => array(
-                    array(
-                        'name'       => 'wcpt_added_to_planning_schedule',
-                        'callback'   => 'send_trigger_added_to_pending_schedule',
                         'priority'   => 10,
                         'parameters' => 1,
@@ -652 +640 @@
 
     /**
-     * Sends e-mails hooked to the wcor_added_to_pending_schedule trigger.
-     *
-     * This fires when a WordCamp is added to the pending schedule.
-     *
-     * @param WP_Post $wordcamp
-     */
-    public function send_trigger_added_to_pending_schedule( $wordcamp ) {
-        $this->send_triggered_emails( $wordcamp, 'wcor_added_to_pending_schedule' );
-    }
-
-    /**
      * Sends e-mails hooked to the wcor_added_to_schedule trigger.
      *