Changeset 5598

Timestamp:

06/27/2017 10:34:19 PM (9 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Handle hook deprecation.

Props DrewAPicture.
Fixes #1766.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc

Files:

• extras.php (modified) (1 diff)
• formatting.php (modified) (2 diffs)
• template-tags.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php

@@ -114 +114 @@
                                         case 'filter_reference':
                                                 $type = __( 'Filter Hook', 'wporg' );
+                                                break;
+                                        case 'action_deprecated':
+                                                $type = __( 'Action Hook (deprecated)', 'wporg' );
+                                                break;
+                                        case 'filter_deprecated':
+                                                $type = __( 'Filter Hook (deprecated)', 'wporg' );
                                                 break;
                                 }

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/formatting.php

@@ -160 +160 @@
          *
          * @param string $link Element string.
-         * @param string HTML link markup if a valid element was found.
-         */
-        public static function link_internal_element( $link ) {
+         * @param bool   $tag  Optional. Whether the element was explicitly provided in a tag
+         *                     description, such as `@see 'hook_name'` vs in random context.
+         *                     Default false.
+         * @return string HTML link markup if a valid element was found.
+         */
+        public static function link_internal_element( $link, $tag = false ) {
                 // Link to class variable: {@see WP_Rewrite::$index}
                 if ( false !== strpos( $link, '::$' ) ) {
@@ -176 +179 @@
                 }
 
-                // Link to hook: {@see 'pre_get_search_form'}
-                elseif ( 1 === preg_match( '/^(?:\'|(?:‘))([\$\w-&;]+)(?:\'|(?:’))$/', $link, $hook ) ) {
+                // Link to hook: {@see 'pre_get_search_form'} (or 'pre_get_search_form' if $tag is true)
+                elseif (
+                        1 === preg_match( '/^(?:\'|(?:‘))([\$\w-&;]+)(?:\'|(?:’))$/', $link, $hook )
+                        || ( true === $tag && 1 === preg_match( '/^(?:\')([\$\w-&;]+)(?:\')$/', $link, $hook ) )
+                ) {
                         if ( ! empty( $hook[1] ) ) {
                                 $link = '<a href="' .

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -556 +556 @@
                         $hook_type = get_post_meta( $post_id, '_wp-parser_hook_type', true );
                         if ( false !== strpos( $hook_type, 'action' ) ) {
-                                $hook_type = ( 'action_reference' === $hook_type ) ? 'do_action_ref_array' : 'do_action';
+                                if ( 'action_reference' === $hook_type ) {
+                                        $hook_type = 'do_action_ref_array';
+                                } elseif ( 'action_deprecated' === $hook_type ) {
+                                        $hook_type = 'do_action_deprecated';
+                                } else {
+                                        $hook_type = 'do_action';
+                                }
                         } else {
-                                $hook_type = ( 'filter_reference' === $hook_type ) ? 'apply_filters_ref_array' : 'apply_filters';
+                                if ( 'filter_reference' === $hook_type ) {
+                                        $hook_type = 'apply_filters_ref_array';
+                                } elseif ( 'filter_deprecated' === $hook_type ) {
+                                        $hook_type = 'apply_filters_deprecated';
+                                } else {
+                                        $hook_type = 'apply_filters';
+                                }
                         }