Changeset 5691

Timestamp:

07/18/2017 05:33:33 PM (9 years ago)

Author:

coffee2code

Message:

Plugin Directory: Remove obsolete JS code related to removed "Tested Up To" metabox.

Should have been done as part of [4212].

Props SergeyBiryukov.
Fixes #2941.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/class-customizations.php (modified) (1 diff)
• js/edit-form.js (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -111 +111 @@
                                 case 'post.php':
                                         wp_enqueue_style( 'plugin-admin-post-css', plugins_url( 'css/edit-form.css', Plugin_Directory\PLUGIN_FILE ), array( 'edit' ), 4 );
-                                        wp_enqueue_script( 'plugin-admin-post-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 4 );
+                                        wp_enqueue_script( 'plugin-admin-post-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 5 );
                                         wp_localize_script( 'plugin-admin-post-js', 'pluginDirectory', array(
                                                 'approvePluginAYS'   => __( 'Are you sure you want to approve this plugin?', 'wporg-plugins' ),

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/js/edit-form.js

@@ -5 +5 @@
 ( function( $, wp, pluginDirectory ) {
         var PluginEdit = {
-                $testedWith: {},
 
                 ready: function() {
-                        PluginEdit.$testedWith   = $( '#tested-with-select' );
-
-                        $( '#submitdiv' )
-                                .on( 'click', '.edit-tested-with',     PluginEdit.editTestedWith )
-                                .on( 'click', '.save-tested-with',     PluginEdit.updateTestedWith )
-                                .on( 'click', '.cancel-tested-with',   PluginEdit.cancelTestedWith )
-                                .on( 'click', '.set-plugin-status',    PluginEdit.setPluginStatus );
+                        $( '#submitdiv' ).on( 'click', '.set-plugin-status', PluginEdit.setPluginStatus );
 
                         _.each( $( '#post-body' ).find( '.comments-box' ), PluginEdit.loadComments );
@@ -38 +31 @@
 
                         $( '#contact-author' ).appendTo( '#plugin-review .inside' );
-                },
-
-                editTestedWith: function() {
-                        if ( PluginEdit.$testedWith.is( ':hidden' ) ) {
-                                PluginEdit.$testedWith.slideDown( 'fast', function() {
-                                        $( 'select', PluginEdit.$testedWith ).focus();
-                                } );
-                                $( this ).hide();
-                        }
-                },
-
-                updateTestedWith: function() {
-                        PluginEdit.$testedWith.slideUp( 'fast' ).siblings( 'button.edit-tested-with' ).show().focus();
-                        $( '#tested-with-display' ).text( $( 'option:selected', PluginEdit.$testedWith ).text() );
-                },
-
-                cancelTestedWith: function() {
-                        $( '#tested-with' ).val( $( '#hidden-tested-with' ).val() );
-                        PluginEdit.updateTestedWith();
                 },
 
@@ -136 +110 @@
                         }
                 }
+
         };