Changeset 5707

Timestamp:

07/20/2017 07:55:53 PM (7 years ago)

Author:

coffee2code

Message:

Plugin Directory: Add custom email subject for rejections and improve translatability of email subjects.

Props Ipstenu, SergeyBiryukov.
Fixes #2677.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

@@ -32 +32 @@
         }
 
-        if ( 'pending' != $post->post_status && 'new' != $post->post_status ) {
+        if ( 'new' !== $post->post_status && 'pending' !== $post->post_status ) {
             echo "<ul>
                 <li><a href='https://plugins.trac.wordpress.org/log/{$post->post_name}/'>" . __( 'Development Log', 'wporg-plugins' ) . "</a></li>
@@ -45 +45 @@
         add_filter( 'wp_comment_reply', function( $string ) use ( $post ) {
             $author = get_user_by( 'id', $post->post_author );
-            
-            $type   = 'Notice';
-            if ( $post->post_status == 'new' || $post->post_status == 'pending' ) {
-                $type = 'Request';
+
+            if ( 'new' === $post->post_status || 'pending' === $post->post_status ) {
+                /* translators: %s: plugin title */
+                $subject = sprintf( __( '[WordPress Plugin Directory] Request: %s', 'wporg-plugins' ), $post->post_title );
+            } elseif ( 'rejected' === $post->post_status ) {
+                /* translators: %s: plugin title */
+                $subject = sprintf( __( '[WordPress Plugin Directory] Rejection Explanation: %s', 'wporg-plugins' ), $post->post_title );
+            } else {
+                /* translators: %s: plugin title */
+                $subject = sprintf( __( '[WordPress Plugin Directory] Notice: %s', 'wporg-plugins' ), $post->post_title );
             }
             
@@ -55 +61 @@
                 <input type="hidden" name="to_email" value="<?php echo esc_attr( $author->user_email ); ?>" />
                 <input type="hidden" name="to_name" value="<?php echo esc_attr( $author->display_name ); ?>" />
-                <input type="hidden" name="subject" value="<?php printf( esc_attr__( '[WordPress Plugin Directory] %s: %s', 'wporg-plugins' ), $type, $post->post_title ); ?>" />
+                <input type="hidden" name="subject" value="<?php echo esc_attr( $subject ); ?>" />
                 <button class="button button-primary" type="submit"><?php _e( 'Contact plugin author', 'wporg-plugins' ); ?></button>
             </form>