Changeset 5758

Timestamp:

08/07/2017 06:02:51 PM (8 years ago)

Author:

coffee2code

Message:

Browse Happy: Pull current browser version number data from Wikidata API rather than parsing Wikimedia markup.

Props Viper007Bond.
See ​https://github.com/WordPress/browsehappy/pull/39.
Fixes #2853.

File:

• sites/trunk/browsehappy.com/public_html/functions.php (modified) (8 diffs)

sites/trunk/browsehappy.com/public_html/functions.php

@@ -11 +11 @@
             'long_name' => 'Google Chrome',
             'wikipedia' => 'Google_Chrome',
+            'wikidata' => 'Q777',
             'normalized' => 1, // just first number
             'facebook' => 'googlechrome',
@@ -20 +21 @@
             'long_name' => 'Mozilla Firefox',
             'wikipedia' => 'Firefox',
+            'wikidata' => 'Q698',
             'normalized' => 1.5, // include second number if non-zero
             'facebook' => 'Firefox',
@@ -29 +31 @@
             'long_name' => 'Apple Safari',
             'wikipedia' => 'Safari',
+            'wikidata' => 'Q35773',
             'normalized' => 1.5, // include second number if non-zero
             'facebook' => false,
@@ -38 +41 @@
             'long_name' => 'Opera',
             'wikipedia' => 'Opera',
+            'wikidata' => 'Q41242',
             'normalized' => 1, // just first number
             'facebook' => 'Opera',
@@ -47 +51 @@
             'long_name' => 'Microsoft Edge',
             'wikipedia' => 'Microsoft_Edge',
+            'wikidata' => 'Q18698690',
             'normalized' => 1, // just first number
             'facebook' => 'MicrosoftEdge',
@@ -56 +61 @@
             'long_name' => 'Microsoft Internet Explorer',
             'wikipedia' => 'Internet_Explorer',
+            'wikidata' => 'Q1575',
             'normalized' => 1, // just first number
             'facebook' => 'internetexplorer',
@@ -80 +86 @@
 function browsehappy_fetch_version( $browser, $normalize = true ) {
 
-    $fragment = browsehappy_get_browser_data( $browser )->wikipedia;
-    if ( ! $fragment )
-        return false;
+    $fragment = browsehappy_get_browser_data( $browser )->wikidata;
+    if ( ! $fragment ) {
+        return false;
+    }
 
     // Unexpiring transients are autoloaded. We expire these manually on cron instead.
     $stored_version = get_transient( 'browsehappy_version_' . $browser );
     if ( false !== $stored_version ) {
-        if ( $normalize )
+        if ( $normalize ) {
             return browsehappy_normalize_version( $browser, $stored_version );
+        }
         return $stored_version;
     }
 
-    $url = 'https://en.wikipedia.org/w/api.php?action=query&prop=revisions&rvprop=content&format=php&titles=Template:Latest_stable_software_release/';
-    $url .= $fragment;
-
-    $response = wp_remote_get( $url );
-
-    if ( is_wp_error( $response ) )
-        return false;
-
-    if ( ! $content = wp_remote_retrieve_body( $response ) )
-        return false;
-
-    if ( ! is_serialized( $content ) )
-        return false;
-
-    $content = maybe_unserialize( $content );
-    $page = array_pop( $content['query']['pages'] );
-    $raw_data = explode( "\n", $page['revisions'][0]['*'] );
-
-    $version = false;
-    foreach( $raw_data as $data ) {
-        $data = trim( $data, '| ' );
-        if ( false !== strpos( $data, 'Android' ) || false !== strpos( $data, 'iOS' ) )
-            continue;
-        if ( false !== strpos( $data, 'Linux' ) && false === strpos( $data, 'Mac OS X' ) && false === strpos( $data, 'Windows' ) && false === strpos( $data, 'Microsoft' ) )
-            continue;
-        if ( ( false !== $pos = strpos( $data, 'latest_release_version' ) ) || ( false !== $pos = strpos( $data, 'latest release version' ) ) ) {
-            if ( $pos )
-                $data = substr( $data, $pos );
-            $version = trim( str_replace( array( 'latest_release_version', 'latest release version', '=' ), '', $data ), '| ' ) . " ";
-            $version = str_replace( "'''Mac OS X''' and '''Microsoft Windows'''<br />", '', $version );
-            $version = str_replace( "'''Windows 10'''<br>", '', $version );
-            $version = substr( $version, 0, strpos( $version, ' ' ) );
-            break;
+    // See https://github.com/WordPress/browsehappy/issues/37
+    $query = "
+        SELECT ?version WHERE {
+            wd:{$fragment} p:P348 [
+                ps:P348 ?version;
+                pq:P548 wd:Q12355314;
+                wikibase:rank wikibase:PreferredRank
+            ].
         }
-    }
-
-    if ( false === $version )
-        return false;
+        LIMIT 1
+    ";
+
+    $request = wp_remote_get( add_query_arg(
+        array(
+            'format' => 'json',
+            'query'  => rawurlencode( $query ),
+        ),
+        'https://query.wikidata.org/bigdata/namespace/wdq/sparql'
+    ) );
+
+    if ( is_wp_error( $request ) ) {
+        return false;
+    }
+
+    $data = json_decode( wp_remote_retrieve_body( $request ) );
+
+    if (
+        empty( $data ) ||
+        empty( $data->results ) ||
+        ! is_array( $data->results->bindings ) ||
+        empty( $data->results->bindings[0] ) ||
+        empty( $data->results->bindings[0]->version ) ||
+        empty( $data->results->bindings[0]->version->value )
+    ) {
+        return false;
+    }
+
+    $version = $data->results->bindings[0]->version->value;
 
     $version = preg_replace( '/[^0-9\.]/', '', $version );
@@ -135 +143 @@
     set_transient( 'browsehappy_version_' . $browser, $version );
 
-    if ( $normalize )
+    if ( $normalize ) {
         return browsehappy_normalize_version( $browser, $version );
+    }
 
     return $version;