Changeset 5913 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php

Timestamp:

09/12/2017 04:49:49 PM (7 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Remove duplicated handbook home link from breadcrumb for handbook home page.

• Adds breadcrumb_trail_items_for_handbook_root()
• Renames breadcrumb_trail_items() to breadcrumb_trail_items_for_hooks()

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php

@@ -117 +117 @@
     add_theme_support( 'post-thumbnails' );
 
-    add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_items', 10, 2 );
+    // Modify default breadcrumbs.
+    add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_items_for_hooks', 10, 2 );
+    add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_items_for_handbook_root', 10, 2 );
 
     add_filter( 'wp_parser_skip_duplicate_hooks', '__return_true' );
@@ -143 +145 @@
  *
  * @param  array $items The breadcrumb trail items
- * @param  array $args  Original arg
+ * @param  array $args  Original args
  * @return array
  */
-function breadcrumb_trail_items( $items, $args ) {
+function breadcrumb_trail_items_for_hooks( $items, $args ) {
     $post_type = 'wp-parser-hook';
 
@@ -162 +164 @@
     // Unset the last element since it shifted up in trail hierarchy
     unset( $items[4] );
+
+    return $items;
+}
+
+/**
+ * Fix breadcrumb for handbook root pages.
+ *
+ * The handbook root/landing pages do not need a duplicated breadcrumb trail
+ * item that simply links to the currently loaded page. The trailing breadcrumb
+ * item is already the unlinked handbook name, which is sufficient.
+ *
+ * @param  array $items The breadcrumb trail items
+ * @param  array $args  Original args
+ * @return array
+ */
+function breadcrumb_trail_items_for_handbook_root( $items, $args ) {
+    // Bail early if not a handbook landing page.
+    if ( ! function_exists( 'wporg_is_handbook_landing_page' ) || ! wporg_is_handbook_landing_page() ) {
+        return $items;
+    }
+
+    // Unset link to current handbook.
+    unset( $items[1] );
 
     return $items;