Changeset 5949

Timestamp:

09/21/2017 07:10:15 PM (6 years ago)

Author:

coffee2code

Message:

Browse Happy API: Mark versions of Internet Explorer earlier than 11 as insecure.

• Adds IE 10 & 11 user-agent strings to test data
• Adds unit test for insecure browsers (currently just testing for IE)

Props SergeyBiryukov.
Fixes #2587.
Fixes ​#core40165.

Location:

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0

Files:

• browsers.php (modified) (1 diff)
• parse.php (modified) (1 diff)
• tests/phpunit/tests/browse-happy.php (modified) (2 diffs)

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/browsers.php

@@ -22 +22 @@
         'Opera'             => '12.11',
         'Safari'            => '5',
-        'Internet Explorer' => '9', // Left at 9 until Windows 7 adopts 10
+        'Internet Explorer' => '11',
     );
 }

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/parse.php

@@ -110 +110 @@
     $data['current_version'] = get_browser_version_from_name( $data['name'] );
     $data['upgrade']         = ( ! empty( $data['current_version'] ) && version_compare( $data['version'], $data['current_version'], '<' ) );
-    $data['insecure']        = ( 'Internet Explorer' == $data['name'] && version_compare( $data['version'], '8', '<' ) );
+    $data['insecure']        = ( 'Internet Explorer' == $data['name'] && version_compare( $data['version'], '11', '<' ) );
 
     return $data;

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

@@ -61 +61 @@
                 'Windows Internet Explorer 9.0',
             ],
+            // #2587
+            [
+                'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0)',
+                'Windows Internet Explorer 10.0',
+            ],
+            // #2587
+            [
+                'Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko',
+                'Windows Internet Explorer 11',
+            ],
             [
                 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.21022)',
@@ -217 +227 @@
     }
 
+    /**
+     * @dataProvider data_browse_happy
+     *
+     * @param string $header 'User-Agent' header value.
+     */
+    function test_insecure_browsers( $header ) {
+        $parsed = browsehappy_parse_user_agent( $header );
+
+        if ( 'Internet Explorer' === $parsed['name'] && version_compare( $parsed['version'], '11', '<' ) ) {
+            $this->assertTrue( $parsed['insecure'] );
+        }
+    }
+
 }