Changeset 5952

Timestamp:

09/21/2017 08:23:28 PM (7 years ago)

Author:

coffee2code

Message:

Browse Happy API: Properly attribute platform for Android instead of as 'Linux'.

Fixes lone remaining failing unit test.

Location:

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0

Files:

• parse.php (modified) (1 diff)
• tests/phpunit/tests/browse-happy.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/parse.php

@@ -43 +43 @@
     ) ) {
         $data['platform'] = $regs['platform'];
+    }
+
+    // Properly set platform if Android is actually being reported.
+    if ( 'Linux' === $data['platform'] && false !== strpos( $user_agent, 'Android' ) ) {
+        $data['platform'] = 'Android';
     }
 

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

@@ -157 +157 @@
             [
                 'Mozilla/5.0 (Linux; U; Android 2.2; en-us; SGH-T959 Build/FROYO) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1',
-                'Linux Mobile Safari 4.0',
+                'Android Mobile Safari 4.0',
             ],
             [