Changeset 5973 for sites/trunk/wordcamp.org/public_html/wp-content/themes/wordcamp-base/comments.php

Timestamp:

09/28/2017 07:11:32 PM (7 years ago)

Author:

coreymckrill

Message:

WordCamp Base: Make sure comment number comparison works as expected

From @sergeybiryukov:

get_comments_number() returns a numeric string, strictly comparing
it to an integer doesn't work as expected

This emulates Twenty Seventeen, which handles the comparison correctly.

Refs #3156

File:

• sites/trunk/wordcamp.org/public_html/wp-content/themes/wordcamp-base/comments.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/themes/wordcamp-base/comments.php

@@ -34 +34 @@
             <h3 id="comments-title">
                 <?php
-                if ( 1 === get_comments_number() ) {
-                    printf(
-                        /* translators: %s: post title */
-                        esc_html_x( 'One Response to &ldquo;%s&rdquo;', 'comments title', 'wordcamporg' ),
-                        '<span>' . get_the_title() . '</span>'
-                    );
+                $comments_number = get_comments_number();
+                if ( '1' === $comments_number ) {
+                    printf(
+                        /* translators: %s: post title */
+                        _x( 'One Response to &ldquo;%s&rdquo;', 'comments title', 'wordcamporg' ),
+                        '<span>' . get_the_title() . '</span>'
+                    );
                 } else {
                     printf(
                         /* translators: 1: number of comments, 2: post title */
-                        esc_html( _nx( '%1$s Response to &ldquo;%2$s&rdquo;', '%1$s Responses to &ldquo;%2$s&rdquo;', get_comments_number(), 'comments title', 'wordcamporg' ) ),
-                        number_format_i18n( get_comments_number() ),
+                        _nx(
+                            '%1$s Response to &ldquo;%2$s&rdquo;',
+                            '%1$s Responses to &ldquo;%2$s&rdquo;',
+                            $comments_number,
+                            'comments title',
+                            'wordcamporg'
+                        ),
+                        number_format_i18n( $comments_number ),
                         '<span>' . get_the_title() . '</span>'
                     );