Changeset 5975

Timestamp:

09/28/2017 10:38:09 PM (3 years ago)

Author:

coffee2code

Message:

Browse Happy API: Bump current version of Safari to 11 and mark versions earlier than 10 as insecure.

Location:

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0

Files:

• browsers.php (modified) (1 diff)
• parse.php (modified) (1 diff)
• tests/phpunit/tests/browse-happy.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/browsers.php

@@ -22 +22 @@
         'Microsoft Edge'    => '15.15063',
         'Opera'             => '12.18',
-        'Safari'            => '5',
+        'Safari'            => '11',
         'Internet Explorer' => '11',
     );

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/parse.php

@@ -163 +163 @@
     } elseif ( 'Opera' === $data['name'] && version_compare( $data['version'], '12.18', '<' ) ) {
         $data['insecure'] = true;
+    } elseif ( 'Safari' === $data['name'] && version_compare( $data['version'], '10', '<' ) ) {
+        $data['insecure'] = true;
     }
 

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

@@ -461 +461 @@
         } elseif ( 'Opera' === $parsed['name'] && version_compare( $parsed['version'], '12.18', '<' ) ) {
             $this->assertTrue( $parsed['insecure'] );
+        } elseif ( 'Safari' === $parsed['name'] && version_compare( $parsed['version'], '10', '<' ) && ! $parsed['mobile'] ) {
+            $this->assertTrue( $parsed['insecure'] );
         } else {
             $this->assertFalse( $parsed['insecure'] );