Changeset 5994

Timestamp:

10/02/2017 08:42:19 PM (7 years ago)

Author:

coffee2code

Message:

Browse Happy API: Add support for Samsung Browser.

Location:

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0

Files:

• parse.php (modified) (2 diffs)
• tests/phpunit/tests/browse-happy.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/parse.php

@@ -76 +76 @@
 
     preg_match_all(
-        '%(?P<name>Opera Mini|Opera|OPR|Edge|UCBrowser|UCWEB|Trident|Silk|Camino|Kindle|Firefox|(?:Mobile )?Safari|NokiaBrowser|MSIE|RockMelt|AppleWebKit|Chrome|IEMobile|Version)(?:[/ ])(?P<version>[0-9.]+)%im',
+        '%(?P<name>Opera Mini|Opera|OPR|Edge|UCBrowser|UCWEB|Trident|Silk|Camino|Kindle|Firefox|SamsungBrowser|(?:Mobile )?Safari|NokiaBrowser|MSIE|RockMelt|AppleWebKit|Chrome|IEMobile|Version)(?:[/ ])(?P<version>[0-9.]+)%im',
         $user_agent,
         $result,
@@ -138 +138 @@
     elseif ( false !== ( $key = array_search( 'Kindle', $result['name'] ) ) ) {
         $data['name']     = 'Kindle Browser';
+        $data['version']  = $result['version'][ $key ];
+    }
+    // Samsung Browser
+    elseif ( false !== ( $key = array_search( 'SamsungBrowser', $result['name'] ) ) ) {
+        $data['name']     = 'Samsung Browser';
         $data['version']  = $result['version'][ $key ];
     }

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

@@ -509 +509 @@
             ],
 
+            // Samsung Browser
+
+            [
+                'Mozilla/5.0 (Linux; Android 5.1.1; SAMSUNG SM-G360T1 Build/LMY47X) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/3.3 Chrome/38.0.2125.102 Mobile Safari/537.36',
+                'Android Samsung Browser 3.3',
+            ],
+            [
+                'Mozilla/5.0 (Linux; Android 7.0; SAMSUNG SM-G950U Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/5.4 Chrome/51.0.2704.106 Mobile Safari/537.36',
+                'Android Samsung Browser 5.4',
+            ],
+            [
+                'Mozilla/5.0 (SMART-TV; Linux; Tizen 2.4.0) AppleWebkit/538.1 (KHTML, like Gecko) SamsungBrowser/1.1 TV Safari/538.1',
+                'Linux Samsung Browser 1.1',
+            ],
+
             // UC Browser