Changeset 6037 for sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

Timestamp:

10/16/2017 10:32:50 PM (8 years ago)

Author:

coffee2code

Message:

Browse Happy API: Refactor to reduce both code duplication and the number of repeated checks performed.

• Compacts near-identical handling for explicitly identifiable browsers into single handler
• Removes individual handlers for 17 browsers
• Adds browsehappy_get_explicit_browser_tokens() to return data for the similarly-handled explicitly identifiable browsers

File:

• sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/core/browse-happy/1.0/tests/phpunit/tests/browse-happy.php

@@ -866 +866 @@
     }
 
+    function test_browsehappy_get_explicit_browser_tokens() {
+        $tokens = browsehappy_get_explicit_browser_tokens();
+
+        $this->assertTrue( is_array( $tokens ) );
+
+        $this->assertArrayHasKey( 'Camino', $tokens );
+        $this->assertEmpty( $tokens['Camino'] );
+
+        $this->assertArrayHasKey( 'S40OviBrowser', $tokens );
+        $this->assertArrayHasKey( 'name', $tokens['S40OviBrowser'] );
+        $this->assertEquals( 'Ovi Browser', $tokens['S40OviBrowser']['name'] );
+        $this->assertArrayHasKey( 'mobile', $tokens['S40OviBrowser'] );
+        $this->assertTrue( $tokens['S40OviBrowser']['mobile'] );
+        $this->assertArrayHasKey( 'platform', $tokens['S40OviBrowser'] );
+        $this->assertEquals( 'Symbian', $tokens['S40OviBrowser']['platform'] );
+    }
+
 }