Changeset 6051

Timestamp:

10/23/2017 10:14:32 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Support Forums: Don't display an empty list item for plugin icon if there's no icon, e.g. because the plugin is closed.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-plugin-directory-compat.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-plugin-directory-compat.php

@@ -94 +94 @@
         }
 
+        $icon       = '';
         $plugin     = sprintf( '<a href="//wordpress.org/plugins/%s/">%s</a>', esc_attr( $this->slug() ), esc_html( $this->plugin->post_title ) );
         $faq        = sprintf( '<a href="//wordpress.org/plugins/%s/faq/">%s</a>', esc_attr( $this->slug() ), __( 'Frequently Asked Questions', 'wporg-forums' ) );
@@ -101 +102 @@
         $reviews    = sprintf( '<a href="%s">%s</a>', home_url( '/plugin/' . esc_attr( $this->slug() ) . '/reviews/' ), __( 'Reviews', 'wporg-forums' ) );
         $create     = '';
+
+        if ( function_exists( 'wporg_get_plugin_icon' ) ) {
+            $icon = wporg_get_plugin_icon( $this->slug, 128 );
+        }
 
         $create_label = '';
@@ -117 +122 @@
         <div>
             <ul>
-                <?php if ( function_exists( 'wporg_get_plugin_icon' ) ) : ?>
-                <li><?php echo wporg_get_plugin_icon( $this->slug, 128 ); ?></li>
+                <?php if ( $icon ) : ?>
+                <li><?php echo $icon; ?></li>
                 <?php endif; ?>
                 <li style="clear:both;"><?php echo $plugin; ?></li>