Changeset 6073 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

Timestamp:

11/02/2017 05:37:31 AM (9 years ago)

Author:

dd32

Message:

Plugin Directory: Bump last_updated when the built ZIP changes, which may be as simple as a readme update.
This restores the behaviour of bumping the Tested up to header to allow plugins to avoid the 2 year unupdated banner.
This also fixes the expectation of last_updated being reflective of the last development changes, for example when the plugin uses trunk as it's stable_tag.

Fixes #2644

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -82 +82 @@
                 $plugin->post_excerpt = trim( $readme->short_description ) ?: $headers->Description ?: $plugin->post_excerpt;
 
-                // Bump last updated if the version has changed, or if the post_modified is empty (which is the case for many initial checkins).
-                if ( ( !isset( $headers->Version ) || $headers->Version != get_post_meta( $plugin->ID, 'version', true ) ) ||
-                         ( $plugin->post_modified == '0000-00-00 00:00:00' ) ) {
+                /*
+                 * Bump last updated if:
+                 * - The version has changed.
+                 * - The post_modified is empty, which is the case for many initial checkins.
+                 * - A tag (or trunk) commit is made to the current stable. The build has changed, even if not new version.
+                 */
+                if (
+                        ( !isset( $headers->Version ) || $headers->Version != get_post_meta( $plugin->ID, 'version', true ) ) ||
+                        $plugin->post_modified == '0000-00-00 00:00:00' ||
+                        ( $svn_changed_tags && in_array( $svn_changed_tags, ( $stable_tag ?: 'trunk' ), true ) )
+                ) {
                         $plugin->post_modified = $plugin->post_modified_gmt = current_time( 'mysql' );
                 }
@@ -136 +144 @@
 
                 foreach ( $this->plugin_headers as $plugin_header => $meta_field ) {
+                        if ( 'Version' == $plugin_header ) {
+                                continue; // We'll specifically update the latest version after everything is built.
+                        }
                         update_post_meta( $plugin->ID, $meta_field, ( isset( $headers->$plugin_header ) ? wp_slash( $headers->$plugin_header ) : '' ) );
                 }
@@ -160 +171 @@
 
                 // Finally, set the new version live.
-                update_post_meta( $plugin->ID, 'stable_tag', $stable_tag );
+                update_post_meta( $plugin->ID, 'stable_tag', wp_slash( $stable_tag ) );
+                update_post_meta( $plugin->ID, 'version',    wp_slash( $headers->Version ) );
 
                 // Ensure that the API gets the updated data