Making WordPress.org


Ignore:
Timestamp:
11/10/2017 02:17:53 AM (6 years ago)
Author:
iandunn
Message:

WordCamp Payments: Add warning/@todo about problematic $back_compat_statuses.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

    r6067 r6106  
    207207        wp_nonce_field( 'status', 'status_nonce' );
    208208
     209        /*
     210         * @todo Remove $back_compat_statuses everywhere.
     211         *
     212         * They add a lot of fragility because they're not DRY and the data isn't consistent and
     213         * predictable. They appear in many of the modules in both the wordcamp-payments and
     214         * wordcamp-payments-network plugins.
     215         *
     216         * It seems like it'd be much better to just run a script over all sites and convert the
     217         * data to the new statuses. Need to investigate why that wasn't done to begin with, in
     218         * case there are some problems that make this more complicated than it appears.
     219         */
    209220        $back_compat_statuses = array(
    210221            'unpaid' => 'draft',
     
    526537
    527538        // Back-compat
     539        // Warning/@todo: See note in render_status_metabox()
    528540        $back_compat_statuses = array(
    529541            'unpaid' => 'draft',
     
    963975            $post = get_post( $entry->post_id );
    964976
     977            // Warning/@todo: See note in render_status_metabox()
    965978            $back_compat_statuses = array(
    966979                'unpaid' => 'draft',
Note: See TracChangeset for help on using the changeset viewer.