Changeset 6106 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

Timestamp:

11/10/2017 02:17:53 AM (9 years ago)

Author:

iandunn

Message:

WordCamp Payments: Add warning/@todo about problematic $back_compat_statuses.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

@@ -207 +207 @@
                 wp_nonce_field( 'status', 'status_nonce' );
 
+                /*
+                 * @todo Remove $back_compat_statuses everywhere.
+                 *
+                 * They add a lot of fragility because they're not DRY and the data isn't consistent and
+                 * predictable. They appear in many of the modules in both the wordcamp-payments and
+                 * wordcamp-payments-network plugins.
+                 *
+                 * It seems like it'd be much better to just run a script over all sites and convert the
+                 * data to the new statuses. Need to investigate why that wasn't done to begin with, in
+                 * case there are some problems that make this more complicated than it appears.
+                 */
                 $back_compat_statuses = array(
                         'unpaid' => 'draft',
@@ -526 +537 @@
 
                 // Back-compat
+                // Warning/@todo: See note in render_status_metabox()
                 $back_compat_statuses = array(
                         'unpaid' => 'draft',
@@ -963 +975 @@
                         $post = get_post( $entry->post_id );
 
+                        // Warning/@todo: See note in render_status_metabox()
                         $back_compat_statuses = array(
                                 'unpaid' => 'draft',