Changeset 6157

Timestamp:

11/22/2017 11:31:00 AM (8 years ago)

Author:

ocean90

Message:

Translate: Don't fill the caches with empty values on query failures.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/cli/class-update-caches.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/inc/cli/class-update-caches.php

@@ -11 +11 @@
     private $cache_group = 'wporg-translate';
 
+    private $running_all = false;
+
     /**
      * Update all caches.
      */
     public function all() {
+        $this->running_all = true;
         $this->contributors_count();
         $this->translation_status();
         $this->existing_locales();
+        $this->running_all = false;
     }
 
@@ -33 +37 @@
         }
 
-        $locales = GP::$translation_set->existing_locales();
+        $locales   = GP::$translation_set->existing_locales();
         $db_counts = $wpdb->get_results(
             "SELECT `locale`, COUNT( DISTINCT user_id ) as `count` FROM {$wpdb->user_translations_count} WHERE `accepted` > 0 GROUP BY `locale`",
             OBJECT_K
         );
+
+        if ( ! $db_counts || ! $locales ) {
+            if ( $this->running_all ) {
+                WP_CLI::warning( 'Retrieving contributors count failed.' );
+                return;
+            } else {
+                WP_CLI::error( 'Retrieving contributors count failed.' );
+            }
+        }
 
         $counts = array();
@@ -61 +74 @@
 
         if ( ! isset( $wpdb->project_translation_status ) ) {
-            WP_CLI::error( 'The stats plugin seems not to be activated.' );
-            return;
+            if ( $this->running_all ) {
+                WP_CLI::warning( 'Retrieving translation status failed: The stats plugin seems not to be activated.' );
+                return;
+            } else {
+                WP_CLI::error( 'Retrieving translation status failed: The stats plugin seems not to be activated.' );
+            }
         }
 
@@ -71 +88 @@
             2, 'default' // 2 = wp/dev
         ), OBJECT_K );
+
+        if ( ! $translation_status ) {
+            if ( $this->running_all ) {
+                WP_CLI::warning( 'Retrieving translation status failed.' );
+                return;
+            } else {
+                WP_CLI::error( 'Retrieving translation status failed.' );
+            }
+        }
 
         wp_cache_set( 'translation-status', $translation_status, $this->cache_group );
@@ -84 +110 @@
         $existing_locales = GP::$translation_set->existing_locales();
 
+        if ( ! $existing_locales ) {
+            if ( $this->running_all ) {
+                WP_CLI::warning( 'Retrieving existing locales failed.' );
+                return;
+            } else {
+                WP_CLI::error( 'Retrieving existing locales failed.' );
+            }
+        }
+
         wp_cache_set( 'existing-locales', $existing_locales, $this->cache_group );
         WP_CLI::success( 'Existing locales were updated.' );