Changeset 6160

Timestamp:

11/22/2017 11:09:15 PM (8 years ago)

Author:

coreymckrill

Message:

WordCamp Post Type: Add note about number formatting

Sanitizing floats with variable comma and decimal point locations
(depending on the locale conventions of the user) turns out to be
quite a challenge. For today, we're going to take the easy way out
and just add a note to the input instructing to not use commas.

This also adds attributes to the number input field to make it more
compatible with a variable number of decimal points.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -1152 +1152 @@
     // @todo When you refactor meta_keys() to support changing labels -- see note in meta_keys() -- also make it support these notes
     $messages = array(
-        'Telephone'                => 'Required for shipping.',
-        'Mailing Address'          => 'Shipping address.',
-        'Physical Address'         => 'Please include the city, state/province and country.', // So it can be geocoded correctly for the map
-        'Global Sponsorship Grant' => 'Deprecated.'
+        'Telephone'                       => 'Required for shipping.',
+        'Mailing Address'                 => 'Shipping address.',
+        'Physical Address'                => 'Please include the city, state/province and country.', // So it can be geocoded correctly for the map
+        'Global Sponsorship Grant Amount' => 'No commas, thousands separators or currency symbols. Ex. 1234.56',
+        'Global Sponsorship Grant'        => 'Deprecated.',
     );
 
@@ -1191 +1192 @@
                         case 'number' : ?>
 
-                            <input type="number" size="16" name="<?php echo $object_name; ?>" id="<?php echo $object_name; ?>" value="<?php echo esc_attr( get_post_meta( $post_id, $key, true ) ); ?>"<?php echo $readonly; ?> />
+                            <input type="number" size="16" name="<?php echo $object_name; ?>" id="<?php echo $object_name; ?>" value="<?php echo esc_attr( get_post_meta( $post_id, $key, true ) ); ?>" step="any" min="0"<?php echo $readonly; ?> />
 
                         <?php break;