Changeset 6217 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

Timestamp:

12/03/2017 07:32:59 PM (9 years ago)

Author:

Otto42

Message:

Plugins: General code cleanup, migrate events that happen on transistions to single place, remove duplicated code, add auditing, simplify logic. props @joostdevalk See #2860

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php (modified) (14 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

@@ -1 +1 @@
 <?php
+
 namespace WordPressdotorg\Plugin_Directory\Admin;
+
 use WordPressdotorg\Plugin_Directory\Tools;
 use WordPressdotorg\Plugin_Directory\Tools\SVN;
@@ -11 +13 @@
  */
 class Status_Transitions {
-
         /**
          * Fetch the instance of the Status_Transitions class.
@@ -32 +33 @@
          *
          * @param string $post_status Plugin post status.
+         *
          * @return array An array of allowed post status transitions.
          */
@@ -72 +74 @@
          * @param array $data    An array of slashed post data.
          * @param array $postarr An array of sanitized, but otherwise unmodified post data.
+         *
          * @return array
          */
@@ -93 +96 @@
 
                 // ...or it's a white-listed status for plugin reviewers.
-                if ( current_user_can( 'plugin_review', $postarr['ID'] ) && in_array( $postarr['post_status'], array( 'new', 'pending' ) ) ) {
+                if ( current_user_can( 'plugin_review', $postarr['ID'] ) && in_array( $postarr['post_status'], array(
+                                'new',
+                                'pending',
+                        ) ) ) {
                         return $data;
                 }
@@ -128 +134 @@
                                 $this->rejected( $post->ID, $post );
                                 break;
+                        case 'publish':
+                                $this->clean_closed_date( $post->ID );
+                                break;
+                        case 'disabled':
+                        case 'closed':
+                                $this->save_close_reason( $post->ID );
+                                break;
                 }
 
@@ -141 +154 @@
          */
         public function approved( $post_id, $post ) {
-                $attachments = get_attached_media( 'application/zip', $post_id );
+                $attachments   = get_attached_media( 'application/zip', $post_id );
                 $plugin_author = get_user_by( 'id', $post->post_author );
 
@@ -178 +191 @@
 
                 /* translators: 1: plugin name, 2: plugin slug */
-                $content  = sprintf( __( 'Congratulations, your plugin hosting request for %1$s has been approved.
+                $content = sprintf( __( 'Congratulations, your plugin hosting request for %1$s has been approved.
 
 Within one hour you will have access to your SVN repository with the WordPress.org username and password you used to log in and submit your request. Your username is case sensitive.
@@ -215 +228 @@
                 );
 
+                $this->audit_log( 'Plugin approved.', $post_id );
                 wp_mail( $plugin_author->user_email, $subject, $content, 'From: plugins@wordpress.org' );
         }
@@ -234 +248 @@
                 wp_update_post( array(
                         'ID'        => $post_id,
-                        'post_name' => sprintf( 'rejected-%s-rejected', $post->post_name )
+                        'post_name' => sprintf( 'rejected-%s-rejected', $post->post_name ),
                 ) );
 
@@ -242 +256 @@
 
                 /* translators: 1: plugin name, 2: plugins@wordpress.org */
-                $content  = sprintf( __( 'Unfortunately your plugin submission for %1$s has been rejected from the WordPress Plugin Directory.
+                $content = sprintf( __( 'Unfortunately your plugin submission for %1$s has been rejected from the WordPress Plugin Directory.
 
 If you believe this to be in error, please email %2$s with your plugin attached as a zip and explain why you feel your plugin should be an exception.
@@ -253 +267 @@
                 );
 
+                $this->audit_log( 'Plugin rejected.', $post_id );
                 wp_mail( $email, $subject, $content, 'From: plugins@wordpress.org' );
         }
@@ -260 +275 @@
          *
          * @param string $dir Directory to search in.
+         *
          * @return string
          */
@@ -279 +295 @@
                 return $plugin_root;
         }
+
+        /**
+         * Deletes the plugin closed date meta field.
+         *
+         * @param integer $post_id Post ID.
+         */
+        public function clean_closed_date( $post_id ) {
+                delete_post_meta( $post_id, 'plugin_closed_date' );
+                delete_post_meta( $post_id, '_close_reason' );
+        }
+
+        /**
+         * Save the reason for closing or disabling a plugin.
+         *
+         * @param int $post_id Post ID.
+         */
+        public function save_close_reason( $post_id ) {
+                if ( ! isset( $_POST['close_reason'] ) ) {
+                        return;
+                }
+
+                if ( ! current_user_can( 'plugin_approve', $post_id ) ) {
+                        return;
+                }
+
+                $close_reason = sanitize_key( $_POST['close_reason'] );
+
+                update_post_meta( $post_id, '_close_reason', $close_reason );
+                update_post_meta( $post_id, 'plugin_closed_date', current_time( 'mysql' ) );
+
+                $this->audit_log( sprintf( 'Plugin closed for: %s', $close_reason ), $post_id );
+        }
+
+        /**
+         * Saves an audit_log comment for the plugin.
+         *
+         * @param string  $message The message for the audit log.
+         * @param integer $post_id The Post ID.
+         */
+        private function audit_log( $message, $post_id ) {
+                $comment = array(
+                        'comment_type'    => 'audit_log',
+                        'comment_post_ID' => $post_id,
+                        'comment_author'  => get_current_user_id(),
+                        'comment_content' => $message,
+                );
+                wp_insert_comment( $comment );
+        }
 }