Changeset 6225

Timestamp:

12/03/2017 09:41:48 PM (9 years ago)

Author:

Otto42

Message:

Plugins: Modify how the plugin pages look for closed plugins.

• Display that the plugin was closed and when (if we have that information)
• Show plugin author a notification box telling them to contact plugins@ if they didn't get an email why
• Hide most of the content from the readme
• Don't display the plugin name, just the slug in its place
• Hide icons, banners, any content from the plugin author
• Leave space for reasons of closure for future enhancement

Fixes #2627. props @joostdevalk, @otto42

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts

Files:

• plugin-single.php (modified) (6 diffs)
• section-advanced.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

@@ -18 +18 @@
 
 ?><article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
-        <?php echo Template::get_plugin_banner( get_post(), 'html' ); ?>
+    <?php
+    // Don't show the plugin banner for closed plugins
+    if ( ! in_array( $status, array( 'closed', 'disabled' ) ) ) {
+            echo Template::get_plugin_banner( get_post(), 'html' );
+    }
+    ?>
 
         <header class="plugin-header">
@@ -24 +29 @@
                         <div class="plugin-notice notice notice-warning notice-alt">
                                 <p><?php _e( 'This plugin <strong>hasn&#146;t been updated in over 2 years</strong>. It may no longer be maintained or supported and may have compatibility issues when used with more recent versions of WordPress.', 'wporg-plugins' ); ?></p>
-                        </div><!-- .plugin-notice -->
+                        </div>
                 <?php endif; ?>
                 <?php if ( 'publish' !== $status ) :
@@ -66 +71 @@
                                 }
             }
+
+                if ( ! in_array( $status, array( 'closed', 'disabled' ) ) ) {
+                                    // the notice for closed and disabled is shown below the Description header, because we don't output the readme there
                         ?>
+            <!-- .plugin-notice -->
                         <div class="plugin-notice notice <?php echo esc_attr( $notice_type ); ?> notice-alt">
                                 <p><?php echo $message; ?></p>
-                        </div><!-- .plugin-notice -->
-
-                        <?php if ( in_array( $status, array( 'closed', 'disabled' ) ) && get_current_user_id() == get_post()->post_author ) : ?>
-                                <div class="plugin-notice notice notice-info notice-alt">
-                                        <p><?php
-                                                printf(
-                                                        /* translators: 1: plugins@wordpress.org */
-                                                        __( 'If you did not request this change, please contact <a href="mailto:%1$s">%1$s</a> for a status. All developers with commit access are contacted when a plugin is closed, with the reasons why, so check your spam email too.', 'wporg-plugins' ),
-                                                        'plugins@wordpress.org'
-                                                );
-                                        ?></p>
-                                </div><!-- .plugin-notice -->
-                        <?php endif; ?>
+                        </div>
+            <!-- .plugin-notice -->
+        <?php } ?>
                 <?php endif; ?>
 
                 <div class="entry-thumbnail">
-                        <?php echo Template::get_plugin_icon( get_post(), 'html' ); ?>
+            <?php
+            // Don't show the icon for closed plugins
+            if ( ! in_array( $status, array( 'closed', 'disabled' ) ) ) {
+                            echo Template::get_plugin_icon( get_post(), 'html' );
+            }
+            ?>
                 </div>
 
@@ -124 +128 @@
                         <?php endif; ?>
                 </div>
-
-                <?php the_title( '<h1 class="plugin-title"><a href="' . esc_url( get_permalink() ) . '">', '</a></h1>' ); ?>
+        
+                <?php
+                if ( in_array( $status, array( 'closed', 'disabled' ) ) ) {
+                        add_filter( 'the_title', function( $title, $id ) {
+                                $post = get_post( $id );
+                                return $post->post_name;
+                        }, 10, 2 );
+                }
+        the_title( '<h1 class="plugin-title"><a href="' . esc_url( get_permalink() ) . '">', '</a></h1>' ); ?>
 
                 <span class="byline"><?php
@@ -150 +161 @@
                 <li id="tablink-description"><a href='#description'><?php _e( 'Details', 'wporg-plugins' ); ?></a></li>
                 <li id="tablink-reviews"><a href='#reviews'><?php _e( 'Reviews', 'wporg-plugins' ); ?></a></li>
-<?php if ( isset( $content[ 'installation' ] ) ) { ?>
+<?php if ( isset( $content[ 'installation' ] ) && ! in_array( $status, array( 'closed', 'disabled' ) ) ) { ?>
                 <li id="tablink-installation"><a href='#installation'><?php _e( 'Installation', 'wporg-plugins' ); ?></a></li>
 <?php } ?>
@@ -169 +180 @@
                                 }
 
-                                $section_content = trim( apply_filters( 'the_content', $content[ $section_slug ], $section_slug ) );
+                                if ( 'description' === $section_slug && in_array( $status, array( 'closed', 'disabled' ) ) ) {
+                                // Don't show the description for closed plugins
+                                        $section_content = '<div class="plugin-notice notice notice-error notice-alt"><p>' . $message . '</p></div>';
+                            if ( get_current_user_id() == get_post()->post_author ) {
+                                    $section_content .= '<div class="plugin-notice notice notice-info notice-alt"><p>' .
+                                                        sprintf(
+                                                        /* translators: 1: plugins@wordpress.org */
+                                                                __( 'If you did not request this change, please contact <a href="mailto:%1$s">%1$s</a> for a status. All developers with commit access are contacted when a plugin is closed, with the reasons why, so check your spam email too.', 'wporg-plugins' ),
+                                                                'plugins@wordpress.org'
+                                                        ) . '</p></div><!-- .plugin-notice -->';
+                            }
+                                }
+                                else if ( in_array( $section_slug, array( 'screenshots', 'installation', 'faq', 'changelog' ) ) && in_array( $status, array( 'closed', 'disabled' ) ) ) {
+                                $section_content = '';
+                                }
+                                else {
+                                        $section_content = trim( apply_filters( 'the_content', $content[ $section_slug ], $section_slug ) );
+                                }
+
                                 if ( empty( $section_content ) ) {
                                         continue;

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/section-advanced.php

@@ -14 +14 @@
 
 <div id="admin" class="section">
+    <?php
+    $status  = get_post_status();
+    if ( in_array( $status, array( 'closed', 'disabled' ) ) ) {
+            echo '<div class="plugin-notice notice notice-error notice-alt"><p>' . __( 'This plugin has been closed and is no longer available for download.', 'wporg-plugins' ) . '</p></div>';
+            if ( get_current_user_id() == get_post()->post_author ) {
+                    echo '<div class="plugin-notice notice notice-info notice-alt"><p>' .
+                                        sprintf(
+                                        /* translators: 1: plugins@wordpress.org */
+                                                __( 'If you did not request this change, please contact <a href="mailto:%1$s">%1$s</a> for a status. All developers with commit access are contacted when a plugin is closed, with the reasons why, so check your spam email too.', 'wporg-plugins' ),
+                                                'plugins@wordpress.org'
+                                        ) . '</p></div><!-- .plugin-notice -->';
+            }
+    }
+
+    ?>
         <h2><?php _e( 'Plugin Stats', 'wporg-plugins' ); ?></h2>