Changeset 6251 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/section-advanced.php

Timestamp:

12/08/2017 05:37:23 PM (9 years ago)

Author:

obenland

Message:

Plugins: Simplify template logic.

Moves most of the logic into template tags to make the single-plugin template it bit easier to understand.

Props joostdevalk.
Fixes #3310.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/section-advanced.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/section-advanced.php

@@ -9 +9 @@
 
 namespace WordPressdotorg\Plugin_Directory\Theme;
-use WordPressdotorg\Plugin_Directory\Plugin_Directory;
 use WordPressdotorg\Plugin_Directory\Template;
+
+global $post;
 ?>
 
 <div id="admin" class="section">
-    <?php
-    $status  = get_post_status();
-    if ( in_array( $status, array( 'closed', 'disabled' ) ) ) {
-            echo '<div class="plugin-notice notice notice-error notice-alt"><p>' . __( 'This plugin has been closed and is no longer available for download.', 'wporg-plugins' ) . '</p></div>';
-            if ( get_current_user_id() == get_post()->post_author ) {
-                    echo '<div class="plugin-notice notice notice-info notice-alt"><p>' .
-                                        sprintf(
-                                        /* translators: 1: plugins@wordpress.org */
-                                                __( 'If you did not request this change, please contact <a href="mailto:%1$s">%1$s</a> for a status. All developers with commit access are contacted when a plugin is closed, with the reasons why, so check your spam email too.', 'wporg-plugins' ),
-                                                'plugins@wordpress.org'
-                                        ) . '</p></div><!-- .plugin-notice -->';
-            }
-    }
+        <?php the_closed_plugin_notice(); ?>
 
-    ?>
         <h2><?php _e( 'Plugin Stats', 'wporg-plugins' ); ?></h2>
 
@@ -46 +34 @@
 
         <?php
-
+        if ( 'publish' === $post->post_status ) {
                 $tags = (array) get_post_meta( $post->ID, 'tagged_versions', true );
-                // Sort the versions by version
+                // Sort the versions by version.
                 usort( $tags, 'version_compare' );
-                // We'll want to add a Development Version if it exists
+                // We'll want to add a Development Version if it exists.
                 $tags[] = 'trunk';
 
@@ -59 +47 @@
                 $tags = array_reverse( $tags );
 
-                if ( $tags && 'publish' === get_post_status() ) {
-                        echo '<h5>' . __( 'Previous Versions', 'wporg-plugins' ) . '</h5>';
+                echo '<h5>' . __( 'Previous Versions', 'wporg-plugins' ) . '</h5>';
+                echo '<div class="plugin-notice notice notice-info notice-alt"><p>' . __( 'Previous versions of this plugin may not be secure or stable and are available for testing purposes only.', 'wporg-plugins' ) . '</p></div>';
 
-                        echo '<div class="plugin-notice notice notice-info notice-alt"><p>' . __( 'Previous versions of this plugin may not be secure or stable and are available for testing purposes only.', 'wporg-plugins' ) . '</p></div>';
+                echo '<select class="previous-versions" onchange="getElementById(\'download-previous-link\').href=this.value;">';
+                foreach ( $tags as $version ) {
+                        $text = ( 'trunk' == $version ? __( 'Development Version', 'wporg-plugins' ) : $version );
+                        printf( '<option value="%s">%s</option>', esc_attr( Template::download_link( $post, $version ) ), esc_html( $text ) );
+                }
+                echo '</select> ';
 
-                        echo '<select class="previous-versions" onchange="getElementById(\'download-previous-link\').href=this.value;">';
-                        foreach ( $tags as $version ) {
-                                $text = ( 'trunk' == $version ? __( 'Development Version', 'wporg-plugins' ) : $version );
-                                printf( '<option value="%s">%s</option>', esc_attr( Template::download_link( $post, $version ) ), esc_html( $text ) );
-                        }
-                        echo '</select> ';
-
-                        printf(
-                                '<a href="%s" id="download-previous-link" class="button">%s</a>',
-                                esc_url( Template::download_link( $post, reset( $tags ) ) ),
-                                __( 'Download', 'wporg-plugins' )
-                        );
-                }
-
+                printf(
+                        '<a href="%s" id="download-previous-link" class="button">%s</a>',
+                        esc_url( Template::download_link( $post, reset( $tags ) ) ),
+                        __( 'Download', 'wporg-plugins' )
+                );
+        }
         ?>
 </div>