Changeset 6302

Timestamp:

12/21/2017 05:45:50 PM (9 years ago)

Author:

SergeyBiryukov

Message:

Support Theme: Simplify wporg_support_get_views().

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/functions.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/functions.php

@@ -111 +111 @@
  */
 function wporg_support_get_views() {
-        $all = bbp_get_views();
-        $ordered = array(
+        $views = array(
                 'all-topics',
                 'no-replies',
@@ -118 +117 @@
                 'taggedmodlook',
         );
-        $found = array();
-        foreach ( $ordered as $view ) {
-                if ( array_key_exists( $view, $all ) ) {
-                        $found[] = $view;
+
+        $output = array();
+
+        foreach ( $views as $view ) {
+                if ( ! bbp_get_view_id( $view ) ) {
+                        continue;
                 }
-        }
-        $view_iterator = 0;
-        $view_count    = count( $found );
-
-        foreach ( $found as $view ) : $view_iterator++; ?>
-
-                <li class="view"><a href="<?php bbp_view_url( $view ); ?>"><?php bbp_view_title( $view ); ?></a></li>
-
-                <?php if ( $view_iterator < $view_count ) : ?>|<?php endif; ?>
-
-        <?php endforeach;
-
-        // Unset variables
-        unset( $view_count, $view_iterator, $view, $found, $all, $ordered );
+
+                $output[] = sprintf( '<li class="view"><a href="%s">%s</a></li>',
+                        esc_url( bbp_get_view_url( $view ) ),
+                        bbp_get_view_title( $view )
+                );
+        }
+
+        echo implode( ' | ', $output );
 }